Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump PyMySql Instrumentation version #1228

Merged
merged 3 commits into from
Oct 9, 2020
Merged

Bump PyMySql Instrumentation version #1228

merged 3 commits into from
Oct 9, 2020

Conversation

lzchen
Copy link
Contributor

@lzchen lzchen commented Oct 9, 2020 •
edited
Loading

Fixes #1227

@lzchen lzchen requested a review from a team October 9, 2020 15:09
codeboten
codeboten reviewed Oct 9, 2020
View reviewed changes
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lzchen can you explain how this fixes that issue in the description?

@lzchen
Copy link
Contributor Author

lzchen commented Oct 9, 2020

@codeboten
Sorry linked the wrong one xD

codeboten
codeboten approved these changes Oct 9, 2020
View reviewed changes
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sounds like something that should be captured in the changelog.

@lzchen lzchen merged commit 5f2cbfa into open-telemetry:master Oct 9, 2020
@lzchen lzchen deleted the pymy branch October 9, 2020 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ocelotl ocelotl ocelotl approved these changes

@codeboten codeboten codeboten approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

opentelemetry-instrumentation-pymysql targeting old PyMySQL version
3 participants
@lzchen @codeboten @ocelotl