Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make controllers configurable in Metrics SDK #798

Closed
lzchen opened this issue Jun 9, 2020 · 1 comment
Closed

Make controllers configurable in Metrics SDK #798

lzchen opened this issue Jun 9, 2020 · 1 comment
Assignees
@lzchen
Labels
discussion Issue or PR that needs/is extended discussion. metrics sdk Affects the SDK package.

Comments

@lzchen
Copy link
Contributor

lzchen commented Jun 9, 2020

As @ocelotl has mentioned in this comment following [#791], add the ability to configure types of controllers to be instantiated and used within a pipeline.

Should be in conjunction with creating a PullController.
@lzchen lzchen added sdk Affects the SDK package. metrics labels Jun 9, 2020
@lzchen lzchen mentioned this issue Jun 9, 2020
Merged
@lzchen lzchen self-assigned this Jun 9, 2020
@codeboten codeboten added the discussion Issue or PR that needs/is extended discussion. label Jun 18, 2020
@codeboten
Copy link
Contributor

Closing this, configuration for metrics should be addressed as part of the work to support configuration files #555

srikanthccv pushed a commit to srikanthccv/opentelemetry-python that referenced this issue Nov 1, 2020
@dyladan
Respect sampled bit in probability sampler (open-telemetry#798)
5228dfa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lzchen lzchen

Labels
discussion Issue or PR that needs/is extended discussion. metrics sdk Affects the SDK package.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@codeboten @lzchen