Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for configuration files #555

Closed
ocelotl opened this issue Apr 6, 2020 · 3 comments
Closed

Add support for configuration files #555

ocelotl opened this issue Apr 6, 2020 · 3 comments
Assignees
@ocelotl
Labels
backlog enhancement New feature or request release:after-ga To be resolved after GA release

Comments

@ocelotl
Copy link
Contributor

ocelotl commented Apr 6, 2020

The current opentelemetry.configuration.Configuration class only gets configuration from environment variables. Make this class get configuration from configuration files too.
@ocelotl ocelotl added enhancement New feature or request api Affects the API package. labels Apr 6, 2020
@ocelotl ocelotl self-assigned this Apr 6, 2020
@ocelotl
Copy link
Contributor Author

ocelotl commented Apr 8, 2020

The idea behind this is that the configuration provided via configuration files can be overridden by the corresponding configuration provided via environment variables, for example:

The configuration file:

meter_provider: meter_provider_0

The environment variable:

OPENTELEMETRY_PYTHON_METER_PROVIDER: meter_provider_1

In this case "meter_provider_1" would be the value present in Configuration().meter_provider.

@ocelotl ocelotl mentioned this issue Apr 8, 2020
Closed
This was referenced Jun 16, 2020
Closed
Closed
@ocelotl ocelotl mentioned this issue Jul 7, 2020
Closed
srikanthccv pushed a commit to srikanthccv/opentelemetry-python that referenced this issue Nov 1, 2020
@ferhatelmas @mayurkale22
fix: typos in comments (open-telemetry#555)
d948f51
@lzchen lzchen added release:after-ga To be resolved after GA release and removed api Affects the API package. labels Dec 18, 2020
@github-actions
Copy link

This issue was marked stale due to lack of activity. It will be closed in 30 days.

@codeboten
Copy link
Contributor

The opentelemetry.configuration.Configuration no longer exists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ocelotl ocelotl

Labels
backlog enhancement New feature or request release:after-ga To be resolved after GA release
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for configuration files ocelotl/opentelemetry-python
3 participants
@codeboten @ocelotl @lzchen