Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement temporality conversion #2329

Closed
aabmass opened this issue Dec 15, 2021 · 0 comments · Fixed by #2380
Closed

Implement temporality conversion #2329

aabmass opened this issue Dec 15, 2021 · 0 comments · Fixed by #2380
Assignees
@ocelotl
Labels
1.10.0rc1 release candidate 1 for metrics GA metrics sdk Affects the SDK package.

Comments

@aabmass
Copy link
Member

aabmass commented Dec 15, 2021

Blocked by #2327

Temporality conversion is specified in the design doc. For this issue:

  • Create a component to handle temporality conversion and storing of previous collection interval's cumulative point value when necessary. For example, there is no need to store previous cumulative for async instruments and cumulative export temporality.
  • Write temporality conversion algorithm. Use the export format added for Create dataclasses for metric exporter batch #2327 as the input and output of the algorithm
@aabmass aabmass added sdk Affects the SDK package. metrics labels Dec 15, 2021
@lzchen lzchen added the 1.10.0rc1 release candidate 1 for metrics GA label Jan 11, 2022
@ocelotl ocelotl self-assigned this Jan 15, 2022
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Jan 15, 2022
@ocelotl
Implement temporality conversion
ab285b8 
Fixes open-telemetry#2329
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Jan 15, 2022
@ocelotl
Add aggregation temporality conversion algorithm
2b4d728 
Fixes open-telemetry#2329
@ocelotl ocelotl mentioned this issue Jan 15, 2022
Merged
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Jan 15, 2022
@ocelotl
Add aggregation temporality conversion algorithm
bf0aae6 
Fixes open-telemetry#2329
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Jan 18, 2022
@ocelotl
Implement temporality conversion
ced22b9 
Fixes open-telemetry#2329
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Jan 18, 2022
@ocelotl
Add aggregation temporality conversion algorithm
e794769 
Fixes open-telemetry#2329
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Feb 1, 2022
@ocelotl
Implement temporality conversion
d2f7c99 
Fixes open-telemetry#2329
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Feb 1, 2022
@ocelotl
Add aggregation temporality conversion algorithm
7325db2 
Fixes open-telemetry#2329
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Feb 2, 2022
@ocelotl
Implement temporality conversion
6d49ab1 
Fixes open-telemetry#2329
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Feb 2, 2022
@ocelotl
Add aggregation temporality conversion algorithm
ad69a3a 
Fixes open-telemetry#2329
ocelotl added a commit that referenced this issue Feb 3, 2022
@ocelotl @srikanthccv @aabmass
Add aggregation temporality conversion algorithm (#2380)
b9815b5 
* Implement temporality conversion

Fixes #2329

* Add aggregation temporality conversion algorithm

Fixes #2329

* Fix start_time_unix_nano

* Update opentelemetry-sdk/src/opentelemetry/sdk/_metrics/aggregation.py

Co-authored-by: Srikanth Chekuri <[email protected]>

* Add warning test

* Update opentelemetry-sdk/src/opentelemetry/sdk/_metrics/aggregation.py

Co-authored-by: Aaron Abbott <[email protected]>

* Add comments to algorigthm

These comments intend to identify the conditional blocks of the
algorithm with the sections defined in the design document.

* Add check for previous point cumulative aggregation temporality

* Added named arguments for gauge

* Change to gauge

* Fix lint

* Remove numbers from comment

* Update opentelemetry-sdk/src/opentelemetry/sdk/_metrics/aggregation.py

Co-authored-by: Srikanth Chekuri <[email protected]>

* Revert "Update opentelemetry-sdk/src/opentelemetry/sdk/_metrics/aggregation.py"

This reverts commit 8bdbe49.

Co-authored-by: Srikanth Chekuri <[email protected]>
Co-authored-by: Aaron Abbott <[email protected]>
Co-authored-by: Alex Boten <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ocelotl ocelotl

Labels
1.10.0rc1 release candidate 1 for metrics GA metrics sdk Affects the SDK package.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add aggregation temporality conversion algorithm ocelotl/opentelemetry-python
3 participants
@aabmass @ocelotl @lzchen