Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create dataclasses for metric exporter batch #2327

Closed
aabmass opened this issue Dec 14, 2021 · 2 comments · Fixed by #2364
Closed

Create dataclasses for metric exporter batch #2327

aabmass opened this issue Dec 14, 2021 · 2 comments · Fixed by #2364
Assignees
@aabmass
Labels
1.10.0rc1 release candidate 1 for metrics GA metrics sdk Affects the SDK package.

Comments

@aabmass
Copy link
Member

aabmass commented Dec 14, 2021

See design doc section on export format. For this issue:

  • Create the dataclasses for each OTLP point type. Can copy paste code from the prototype
  • Update the MetricExporter definition to consume an Iterable[Metric]
@aabmass aabmass added sdk Affects the SDK package. metrics labels Dec 14, 2021
@aabmass aabmass self-assigned this Dec 14, 2021
This was referenced Dec 14, 2021
Closed
Closed
Closed
@ocelotl
Copy link
Contributor

ocelotl commented Dec 15, 2021

I think #2308 fixes this issue 👍

@aabmass
Copy link
Member Author

aabmass commented Dec 15, 2021

Ya, looks like it mostly fixes it. But will still need a few more things I think

@codeboten codeboten mentioned this issue Jan 7, 2022
Merged
6 tasks
@codeboten codeboten added the 1.10.0rc1 release candidate 1 for metrics GA label Jan 11, 2022
@aabmass aabmass mentioned this issue Jan 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aabmass aabmass

Labels
1.10.0rc1 release candidate 1 for metrics GA metrics sdk Affects the SDK package.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Complete metric exporter format and update OTLP exporter aabmass/opentelemetry-python
3 participants
@codeboten @aabmass @ocelotl