Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update limits implementation to correctly deal with empty and negative values. #2052

Closed
owais opened this issue Aug 18, 2021 · 0 comments · Fixed by #2054
Closed

Update limits implementation to correctly deal with empty and negative values. #2052

owais opened this issue Aug 18, 2021 · 0 comments · Fixed by #2054
Assignees
@owais
Labels
feature-request

Comments

@owais
Copy link
Contributor

owais commented Aug 18, 2021 •
edited
Loading

According to the spec

Empty value is treated as infinity. Non-integer and negative values are invalid.

We should ensure out limits implementation takes this into account.
@owais owais self-assigned this Aug 18, 2021
@owais owais mentioned this issue Aug 18, 2021
Merged
12 tasks
owais added a commit to owais/opentelemetry-python that referenced this issue Aug 18, 2021
@owais
SpanLimit: Treat empty value env vars as unset
891233f 
Fixes open-telemetry#2052
@owais owais mentioned this issue Aug 18, 2021
Merged
12 tasks
owais added a commit to owais/opentelemetry-python that referenced this issue Aug 18, 2021
@owais
SpanLimit: Treat empty value env vars as unset
32390f4 
Fixes open-telemetry#2052
owais added a commit to owais/opentelemetry-python that referenced this issue Aug 18, 2021
@owais
SpanLimit: Treat empty value env vars as unset
18574c4 
Fixes open-telemetry#2052
owais added a commit that referenced this issue Aug 24, 2021
@owais @lzchen
Fix limit env vars unset/unlimited values (#2054)
b5704d5 
* Added support for `OTEL_SPAN_ATTRIBUTE_VALUE_LENGTH_LIMIT`

Fixes #2045
Fixes #2043
Fixes #2042
Fixes #2041

* SpanLimit: Treat empty value env vars as unset

Fixes #2052

* Update CHANGELOG.md

Co-authored-by: Leighton Chen <[email protected]>

Co-authored-by: Leighton Chen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@owais owais

Labels
feature-request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix limit env vars unset/unlimited values owais/opentelemetry-python
1 participant
@owais