Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infra: improve tox for local development #2999

Merged
merged 17 commits into from
Dec 17, 2024
Merged

Conversation

emdneto
Copy link
Member

@emdneto emdneto commented Nov 13, 2024

Description

Same as open-telemetry/opentelemetry-python#4238
Prepare tox for tox-uv

@emdneto emdneto requested a review from a team as a code owner November 13, 2024 23:04
docs-requirements.txt Outdated Show resolved Hide resolved
Signed-off-by: emdneto <[email protected]>
@emdneto emdneto marked this pull request as draft November 14, 2024 00:21
Signed-off-by: emdneto <[email protected]>
tox.ini Show resolved Hide resolved
tox.ini Show resolved Hide resolved
Signed-off-by: emdneto <[email protected]>
@emdneto emdneto marked this pull request as ready for review November 14, 2024 01:11
@emdneto emdneto added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Nov 14, 2024
Copy link
Member Author

@emdneto emdneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't update [testenv:docs] because it's failing: https://github.com/open-telemetry/opentelemetry-python-contrib/actions/runs/11827704954/job/32956450432

One solution would be separate docs-requirements.txt in two requirements-files (docs-requirements.txt and readthedocs.txt and use the appropriate one for .readthedocs.yml.

Updated docs-requirements.txt to not use editable installs pypa/pip#12502

Signed-off-by: emdneto <[email protected]>
docs-requirements.txt Outdated Show resolved Hide resolved
Copy link
Contributor

@xrmx xrmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a tox expert but it simplifies tox.ini and removes 200 lines so LGTM

@xrmx xrmx merged commit 59ecd4d into open-telemetry:main Dec 17, 2024
573 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build & infra Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants