-
Notifications
You must be signed in to change notification settings - Fork 620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add http.target
to Django duration metric attributes
#2624
Conversation
...nstrumentation-django/src/opentelemetry/instrumentation/django/middleware/otel_middleware.py
Show resolved
Hide resolved
Changed |
|
...nstrumentation-django/src/opentelemetry/instrumentation/django/middleware/otel_middleware.py
Outdated
Show resolved
Hide resolved
...nstrumentation-django/src/opentelemetry/instrumentation/django/middleware/otel_middleware.py
Show resolved
Hide resolved
…-contrib into django-metrics-route
instrumentation/opentelemetry-instrumentation-fastapi/tests/test_fastapi_instrumentation.py
Outdated
Show resolved
Hide resolved
http.route
to Django duration metric attributeshttp.target
to Django duration metric attributes
This should be mergeable now. Only thing I'm unsure about is the changelog entry. This doesn't need a documentation update, right? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the change @alexmojaki ! I know the semantic convention stuff was confusing haha.
Description
This is similar to #2621 which is for #1457, but this PR is for Django rather than Flask.
It adds the
http.target
attribute to the metric namedhttp.server.duration
.Type of change
Please delete options that are not relevant.
"New feature" feels right and I've chosen it to match #2621 and its changelog update. Arguably this is a bug fix because the attribute is required by the spec, and technically it could be considered a breaking change because this will increase the number of metric data points emitted, but the attribute has low cardinality.
How Has This Been Tested?
The existing test failed until I updated it to also expect the
http.target
attribute.Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.