-
Notifications
You must be signed in to change notification settings - Fork 620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
flask: add http.target
and http.route
to metric attributes
#2621
Merged
lzchen
merged 27 commits into
open-telemetry:main
from
GonzaloGuasch:feature/http-route-in-metric
Jul 22, 2024
Merged
flask: add http.target
and http.route
to metric attributes
#2621
lzchen
merged 27 commits into
open-telemetry:main
from
GonzaloGuasch:feature/http-route-in-metric
Jul 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
alexmojaki
reviewed
Jun 19, 2024
...tion/opentelemetry-instrumentation-flask/src/opentelemetry/instrumentation/flask/__init__.py
Outdated
Show resolved
Hide resolved
instrumentation/opentelemetry-instrumentation-flask/tests/test_programmatic.py
Outdated
Show resolved
Hide resolved
This was referenced Jun 19, 2024
|
GonzaloGuasch
force-pushed
the
feature/http-route-in-metric
branch
from
June 24, 2024 20:50
1da6305
to
3e0ba7d
Compare
emdneto
reviewed
Jun 24, 2024
...tion/opentelemetry-instrumentation-flask/src/opentelemetry/instrumentation/flask/__init__.py
Outdated
Show resolved
Hide resolved
xrmx
reviewed
Jul 1, 2024
GonzaloGuasch
changed the title
flask: add http.route to metric attributes
flask: add Jul 1, 2024
http.route
to metric attributes
emdneto
reviewed
Jul 8, 2024
alexmojaki
reviewed
Jul 16, 2024
...tion/opentelemetry-instrumentation-flask/src/opentelemetry/instrumentation/flask/__init__.py
Outdated
Show resolved
Hide resolved
emdneto
reviewed
Jul 16, 2024
instrumentation/opentelemetry-instrumentation-flask/tests/test_programmatic.py
Outdated
Show resolved
Hide resolved
xrmx
changed the title
flask: add
flask: add Jul 18, 2024
http.route
to metric attributeshttp.target
and http.route
to metric attributes
alexmojaki
reviewed
Jul 18, 2024
...tion/opentelemetry-instrumentation-flask/src/opentelemetry/instrumentation/flask/__init__.py
Outdated
Show resolved
Hide resolved
emdneto
reviewed
Jul 18, 2024
...tion/opentelemetry-instrumentation-flask/src/opentelemetry/instrumentation/flask/__init__.py
Outdated
Show resolved
Hide resolved
alexmojaki
approved these changes
Jul 18, 2024
emdneto
reviewed
Jul 18, 2024
...tion/opentelemetry-instrumentation-flask/src/opentelemetry/instrumentation/flask/__init__.py
Outdated
Show resolved
Hide resolved
emdneto
approved these changes
Jul 19, 2024
lzchen
reviewed
Jul 19, 2024
...tion/opentelemetry-instrumentation-flask/src/opentelemetry/instrumentation/flask/__init__.py
Outdated
Show resolved
Hide resolved
alexmojaki
reviewed
Jul 19, 2024
...tion/opentelemetry-instrumentation-flask/src/opentelemetry/instrumentation/flask/__init__.py
Outdated
Show resolved
Hide resolved
alexmojaki
approved these changes
Jul 20, 2024
xrmx
approved these changes
Jul 22, 2024
lzchen
approved these changes
Jul 22, 2024
emdneto
pushed a commit
to emdneto/opentelemetry-python-contrib
that referenced
this pull request
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Taking up this closed PR, when sending metrics in the Flask instrumentation, the http.route attribute is added to them.
This attribute is super important in the use of metrics and will greatly improve the experience of using Flask. This change was tested locally.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
running: tox -e test-instrumentation-flask
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.