Allow to modify the computed Span name via callback.

[pilhuhn]

Description

With Redis and Databases in a traces, there is no easy way from the span name to see if a "SELECT" is going to Redis or the database.

Type of change

Please delete options that are not relevant.

• New feature (non-breaking change which adds functionality)

How Has This Been Tested?

• TestRedis::test_name_callback

Does This PR Require a Core Repo Change?

• Yes. - Link to PR:
• No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

• [?] Followed the style guidelines of this project
• Changelogs have been updated
• Unit tests have been added
• Documentation has been updated

[srikanthccv]

We removed the name_callback and added request_hook and response_hook. They can be used to change the default span name if needed. You could do something like this.

def request_hook(span, instance, args, kwargs):
  if span.is_recording():
    span.update_name("my-custom-name")

[pilhuhn]

Hm. I got the recommendation to add the name_callback on Slack (https://cloud-native.slack.com/archives/C01PD4HUVBL/p1666969756061799). Will try your suggestion.

[srikanthccv]

Take a look at #411. We are getting rid of it in favour of request/response hooks. It will be removed eventually for requests instrumentation. Aaron might not be aware of this detail. And here is another rejected proposal #1175. Please try the suggested method and let us know if that doesn't solve your issue.

[pilhuhn]

Ok, the following works for me:

    def redis_response_hook(span, instance, response):
      if span.is_recording():
          name = span.name
          name = "Redis " + name
          span.update_name(name)

    from opentelemetry.instrumentation.redis import RedisInstrumentor
    RedisInstrumentor().instrument(response_hook=redis_response_hook)