Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: opentelemetry-instrumentation-urllib3 add support for custom span names via callback #1175

Closed
ZachTB123 opened this issue Jul 1, 2022 · 4 comments
Labels

Comments

@ZachTB123
Copy link

opentelemetry-instrumentation-urllib3 always uses a default span name here. It would be nice if a custom name callback was supported like opentelemetry-instrumentation-requests does here.

@srikanthccv srikanthccv added good first issue Good for newcomers help wanted Extra attention is needed labels Sep 9, 2022
@avzis
Copy link
Contributor

avzis commented Sep 13, 2022

hi, can you assign this to me? thanks :)

@lzchen
Copy link
Contributor

lzchen commented Sep 13, 2022

@avzis
We are actually getting rid of span name callbacks in favor of request/response hooks. PTAL at #411 and implement it using hooks instead of callbacks if you are still interested in working on this.

@avzis avzis removed their assignment Sep 22, 2022
@pgadige
Copy link

pgadige commented Oct 25, 2022

@lzchen PR #576 implements it using hooks. Is there additional work to add on top of these changes?
cc: @srikanthccv

@srikanthccv
Copy link
Member

I believe this is no longer required.

@srikanthccv srikanthccv closed this as not planned Won't fix, can't repro, duplicate, stale Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants