-
Notifications
You must be signed in to change notification settings - Fork 621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gRPC Instrumentation - Support of metrics, messages as span events, conformity to official grpc.ClientInterceptor and bug fixes #1226
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r and raised exception
… metric attributes
…rib into grpc_dev
… of metrics, tracing of messages and changed API to officical grpc.ClientInterceptor API
|
…r and raised exception
… metric attributes
…rib into grpc_dev
… of metrics, tracing of messages and changed API to officical grpc.ClientInterceptor API
…rib into grpc_dev
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Major Redesign of gRPC Instrumentation, including:
New Feature
OpenTelemetryClientInterceptor
-interface to officialgrpc.ClientInterceptor
-interfaceBug Fixes
code()
anddetails()
(opentelemetry-instrumentation-grpc - code()/details()-bug in ServicerContext #855 )abort()
,cancel()
,set_code()
/set_details()
,raise Exception()
abort()
,cancel()
,set_code()
/set_details()
,raise Exception()
grpc.Call
,grpc.Future
,grpc.RpcError
andIterator
Fixes # (issue)
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
tox -e test-instrumentation-grpc
runs adaptedinstrumentation/opentelemetry-instrumentation-grpc/tests/test_client_interceptor.py
andinstrumentation/opentelemetry-instrumentation-grpc/tests/test_server_interceptor.py
which test metrics, creation of span events and conformity of interfaces on client-sideDoes This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.