added RPC system as enum

open-telemetry · Jul 20, 2022 · c04959e · c04959e
1 parent 62e0a31
commit c04959e
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/...tion/opentelemetry-instrumentation-grpc/src/opentelemetry/instrumentation/grpc/_server.py b/...tion/opentelemetry-instrumentation-grpc/src/opentelemetry/instrumentation/grpc/_server.py
@@ -29,7 +29,7 @@
 from opentelemetry import trace
 from opentelemetry.context import attach, detach
 from opentelemetry.propagate import extract
-from opentelemetry.semconv.trace import SpanAttributes
+from opentelemetry.semconv.trace import RpcSystemValues, SpanAttributes
 from opentelemetry.trace.status import Status, StatusCode
 
 logger = logging.getLogger(__name__)
@@ -206,7 +206,7 @@ def _start_span(
 
         # standard attributes
         attributes = {
-            SpanAttributes.RPC_SYSTEM: "grpc",
+            SpanAttributes.RPC_SYSTEM: RpcSystemValues.GRPC.value,
             SpanAttributes.RPC_GRPC_STATUS_CODE: grpc.StatusCode.OK.value[0],
         }
 
@@ -217,8 +217,8 @@ def _start_span(
             )
             attributes.update(
                 {
-                    SpanAttributes.RPC_METHOD: method,
                     SpanAttributes.RPC_SERVICE: service,
+                    SpanAttributes.RPC_METHOD: method,
                 }
             )