Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update metrics top comments and structure #178

Merged
merged 1 commit into from
Jul 22, 2020
Merged

Update metrics top comments and structure #178

merged 1 commit into from
Jul 22, 2020

Conversation

bogdandrutu
Copy link
Member

@bogdandrutu bogdandrutu commented Jul 21, 2020 •
edited
Loading

Fixes #177
Fixes #124

This PR is extracted from #168 and a huge thanks goes to @jmacd. It is updated for the current state, but I heard more people complaining about this and thought it is good to fix now.

@bogdandrutu bogdandrutu requested review from a team July 21, 2020 21:11
@bogdandrutu bogdandrutu mentioned this pull request Jul 21, 2020
Closed
@bogdandrutu
Copy link
Member Author

Thanks for the review @cijothomas

@bogdandrutu bogdandrutu merged commit dfa8c32 into open-telemetry:master Jul 22, 2020
@jmacd jmacd mentioned this pull request Jul 23, 2020
Closed
@bogdandrutu bogdandrutu deleted the docmetric branch February 1, 2021 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cijothomas cijothomas cijothomas approved these changes

@jmacd jmacd jmacd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@bogdandrutu @jmacd @cijothomas