Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MetricDescriptor comment to reflect the label key-value structure properly #177

Closed
nilebox opened this issue Jul 21, 2020 · 0 comments · Fixed by #178
Closed

Update MetricDescriptor comment to reflect the label key-value structure properly #177

nilebox opened this issue Jul 21, 2020 · 0 comments · Fixed by #178

Comments

@nilebox
Copy link
Member

nilebox commented Jul 21, 2020

The comment on MetricDescriptor currently states that label keys are part of the MetricDescripror, while label values are defined in each data point:

// | | ||label|label|...|label| |
// | data|--+ ||key1 |key2 | |keyN | |

This has been changed in #102 to each data point having key-value pairs for labels:

// The set of labels that uniquely identify this timeseries.
repeated opentelemetry.proto.common.v1.StringKeyValue labels = 1;
, so this comment needs to be updated as well.

/cc @bogdandrutu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant