For WINDOWS build!

[wantedxnn]

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: wantedxnn / name: X3N0N (eb0812b, 5fd1821, 180dd46, efa76de, 0c88509, 0fbd7f1, c9f8016, 45d9e5c, 0b2e9f2, 348b2df, 7bb7448, c78376e, 4723806, 2b156fe, 593493f)

[wantedxnn]

Now extension can be compiled and loaded dynamic(shared) or static (tests 005.phpt and 006.phpt skiped because windows use backslash \ also the rest tests XFAIL-ed because error is writed in error_log)

[brettmc]

Thanks for your contribution, @wantedxnn

tests 005.phpt and 006.phpt skiped because windows use backslash \

Are you referring to the /'s in the EXPECTF output? If that's the only problem, I think you could swap /'s for %c according to https://qa.php.net/phpt_details.php#expectf_section

Otherwise, I'd be happy to accept this as-is, although I'd like to see windows added to the build matrix in the future.

[wantedxnn]

Thanks for your contribution, @wantedxnn

tests 005.phpt and 006.phpt skiped because windows use backslash \

Are you referring to the /'s in the EXPECTF output? If that's the only problem, I think you could swap /'s for %c according to https://qa.php.net/phpt_details.php#expectf_section

Otherwise, I'd be happy to accept this as-is, although I'd like to see windows added to the build matrix in the future.

Thanks for your contribution, @wantedxnn

tests 005.phpt and 006.phpt skiped because windows use backslash \

Are you referring to the /'s in the EXPECTF output? If that's the only problem, I think you could swap /'s for %c according to https://qa.php.net/phpt_details.php#expectf_section

Otherwise, I'd be happy to accept this as-is, although I'd like to see windows added to the build matrix in the future.

Fixed! used %e instead %c this will use accordingly OS the corerct separator.

@brettmc And yes...only that was the problem.

[brettmc]

@wantedxnn are you able to provide some basic instructions/docs on how to build on Windows?

[wantedxnn]

@brettmc Sorry for late response ...
Yes of course!
Need more details than this?

https://wiki.php.net/internals/windows/stepbystepbuild_sdk_2

Maby can add also github action to build extension for windows
https://github.com/cmb69/setup-php-sdk

[brettmc]

Need more details than this?
https://wiki.php.net/internals/windows/stepbystepbuild_sdk_2

If these instructions work for you, then I'm happy to just link to them. Specifically, was it this section? https://wiki.php.net/internals/windows/stepbystepbuild_sdk_2#building_pecl_extensions_with_phpize

Maby can add also github action to build extension for windows

I'd love to have this, otherwise we will accidentally break windows build in the future. I will check it out.

[wantedxnn]

@brettmc I don't used phpize .... I have a very custom php-sdk environment because i compile almost 200 extensions (ported from Linux to windows or upgraded from php5 to php8, all deps are updated to last version also instead compiling in vs16(aka Visual studio 2019) i compile everything in vs17( aka Visual studio 2022) I have splinted number of extension per build ( 1st build it's only php source as is building snapshot and pgo optimized with avx2 enabled 2nd build all extensions depending by other extension and 3rd build for all non dependending extensions)

But i will try in this evening to build/compile with phpize (i will need to use my artifact development pack from my top described build )

[wantedxnn]

@brettmc I see already did PR for windows build action :)
Yes indeed can folow the instruction from wiki.php.net using phpize will compile the extension flawless :)