Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[opentelemetry-php-instrumentation] - support windows build/install #1175

Closed
pdelewski opened this issue Feb 9, 2023 · 6 comments
Closed
Labels
enhancement New feature or request help wanted This issue is looking for someone to work on it

Comments

@pdelewski
Copy link
Member

pdelewski commented Feb 9, 2023

Below output from pickle on windows

 - Installing opentelemetry-php-instrumentation (main): Cloning main from cache
+-----------------------------------+----------------------+
| Package name                      | otel_instrumentation |
| Package version (current release) | 0.1.0                |
| Package status                    | stable               |
+-----------------------------------+----------------------+
The following error(s) happened: configure failed, see log at C:\Users\Asus\AppData\Local\Temp/pickle-3e24204e5eacf84484f747338de912d07fcf217f\config.log
1: phpsdk_setvars
2:
1: phpize
2: Rebuilding configure.js
2: c:\php\sdk
2: module ...
2: Now run 'configure --help'
1: C:\Users\Asus\AppData\Local\Temp\opentelemetry-php-instrumentation/configure --enable-otel_instrumentation=shared --enable-debug-pack --enable-otel_instrumentation --with-prefix=c:\php
2: C:\Users\Asus\AppData\Local\Temp\pickle-3e24204e5eacf84484f747338de912d07fcf217f\configure.js(4202, 64) Microsoft JScript - compilation error: expected ')'
2:

This seems to be a problem with php-sdk itself

@brettmc
Copy link
Collaborator

brettmc commented Jul 5, 2023

@pdelewski is this worth trying again using pecl, now that we have it?

@pdelewski
Copy link
Member Author

@brettmc Yes, will check that

@brettmc brettmc changed the title Installation via pickle on windows is failing support windows build/install Aug 31, 2023
@brettmc brettmc added enhancement New feature or request and removed bug Something isn't working labels Aug 31, 2023
@wantedxnn
Copy link

@pdelewski Added pull request for windows build (work only on static build)

@pdelewski
Copy link
Member Author

@wantedxnn Thank you, good job!

@wantedxnn
Copy link

@pdelewski With pleasure, I'm glad I could help!

@brettmc
Copy link
Collaborator

brettmc commented Sep 21, 2023

@brettmc brettmc closed this as completed Sep 21, 2023
@bobstrecansky bobstrecansky changed the title support windows build/install [opentelemetry-php-instrumentation] - support windows build/install Dec 8, 2023
@bobstrecansky bobstrecansky transferred this issue from open-telemetry/opentelemetry-php-instrumentation Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted This issue is looking for someone to work on it
Projects
None yet
Development

No branches or pull requests

3 participants