Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: throwing new exception from post hook lead to memory leak #18

Merged
merged 1 commit into from
Nov 24, 2022

Conversation

pdelewski
Copy link
Member

@pdelewski pdelewski commented Nov 24, 2022

All tests are passing now on debug build without memory problems

=====================================================================
PHP         : /Users/pdelewski/php-bin/DEBUG/bin/php 
PHP_SAPI    : cli
PHP_VERSION : 8.2.0-dev
ZEND_VERSION: 4.2.0-dev

=====================================================================
TIME START 2022-11-24 11:27:20
=====================================================================
PASS Check if otel_instrumentation is loaded [tests/001.phpt] 
PASS Check if hook returns true [tests/002.phpt] 
PASS Check if hooks are invoked [tests/003.phpt] 
PASS Check if multiple hooks are invoked [tests/004.phpt] 
PASS Check if hooks receives function information [tests/005.phpt] 
PASS Check if hooks receives arguments and return value [tests/006.phpt] 
PASS Check if hook receives exception [tests/007.phpt] 
PASS Check if hook can modify arguments [tests/008.phpt] 
PASS Check if hook can modify not provided arguments [tests/009.phpt] 
PASS Check if hook can modify return value [tests/010.phpt] 
PASS Check if hooks are invoked for closures [tests/function_closure.phpt] 
PASS Check if hooks are invoked for first class callables [tests/function_first_class_callable.phpt] 
PASS Check if hooks receive modified exception [tests/multiple_hooks_modify_exception.phpt] 
PASS Check if hooks receive modified arguments [tests/multiple_hooks_modify_params.phpt] 
PASS Check if hooks receive modified returnvalue [tests/multiple_hooks_modify_returnvalue.phpt] 
XFAIL Check if hooks are invoked only once for reimplemented interfaces [tests/reimplemented_interface.phpt]   XFAIL REASON: Repeated interfaces are not deduplicated, A::m() hook is added for C->A and C->B->A.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants