fix: throwing new exception from post hook lead to memory leak (#18)

open-telemetry · Nov 24, 2022 · ab6fee6 · ab6fee6
1 parent 763de42
commit ab6fee6
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/otel_observer.c b/otel_observer.c
@@ -263,11 +263,16 @@ static void observer_end(zend_execute_data *execute_data, zval *retval, zend_lli
                 }
             }
         }
-        
+
         if (UNEXPECTED(EG(exception))) {
+            if (exception) {
+                OBJ_RELEASE(exception);
+            }
+            OBJ_RELEASE(Z_OBJ(params[3]));
+
             ZVAL_OBJ_COPY(&params[3], EG(exception));
         }
-        
+
         zend_exception_restore();
         EG(prev_exception) = exception;
         zend_exception_restore();