Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use unique label and selector for operator objects #697

Merged
merged 1 commit into from
Feb 9, 2022

Conversation

pavolloffay
Copy link
Member

Signed-off-by: Pavol Loffay [email protected]

Resolves #652

Example objects.yaml:
out.txt

@pavolloffay pavolloffay requested review from a team and Aneurysm9 February 9, 2022 10:10
@pavolloffay
Copy link
Member Author

@rbaumgar could you please review?

Copy link
Member

@jpkrohling jpkrohling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be merged for 0.43.0, or should we wait for 0.44.0, which can be done right after 0.43.0?

@pavolloffay
Copy link
Member Author

I don't have any preference, but it seems safe to get it merged

@jpkrohling
Copy link
Member

@yuriolisa, given that there are changes requested in the PR preparing the 0.43 release, I'll merge this now. Please, include it in the changelog for 0.43.0.

@jpkrohling jpkrohling merged commit 8dfb7a5 into open-telemetry:main Feb 9, 2022
@rbaumgar
Copy link

rbaumgar commented Feb 9, 2022

@jpkrohling looks good!
is the operator somehow based on the Operator SDK? If yes, shouldn't this be somehow feedback to the SDK team? Because this is not the first project having this problem.

ItielOlenick pushed a commit to ItielOlenick/opentelemetry-operator that referenced this pull request May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

failed calling webhook "mopentelemetrycollector.kb.io"
3 participants