-
Notifications
You must be signed in to change notification settings - Fork 450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Otel Operator release 0.43.0 #680
Conversation
I'm wondering if I should prepare a routine upgrade for the following change: |
+1 |
I see readyReplicas has been removed from Deployment status, can you update e2e tests please? Update: |
Tests restarted. |
@yuriolisa can you create the upgrade routine PR for |
Hi @VineethReddy02, I was involved with another project last week. I'll be working on that today. |
@pavolloffay , @VineethReddy02 , @jpkrohling . Could you please review this PR? |
What is the status on this PR? We're blocked on an Operator release - should this PR be closed and a 0.44 release be started? We can help with releases :-) |
Working on the 0.44.0 release might be a good exercise for @erichsueh3. |
The linting check is still failing. Could you also please add #697 as part of the changelog? |
Thanks for the excellent suggestion @jpkrohling! @erichsueh3 pl shadow @yuriolisa to help with the releases. |
@alolita, I'll help @erichsueh3 on the next release. |
@yuriolisa @jpkrohling sounds good! |
@VineethReddy02 , could you please review it again? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few indentation nits. Overall LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, please clean the empty lines like @VineethReddy02 suggested. It helps with readability.
* Otel Operator release 0.43.0 * Fixing typo * Upgrade script to version 0.43.0 * Including versions reference * Fixing Lint tests * Adding metrics changes into CHANGELOG * Removed comment and fixed changelog * Added new PR on Changelog and added lint fixes * Added missing header * Fixing upgrade routine * Adding missing operator-sdk PR * Change method of sorting args and fixing test * fixing test logic * Change method of sorting args and fixing test * Fixed Changelog links * Fixed Changelog links * Change lint format on version tests * Fixed typos on test * Fixed typos on test * Fixed Changelog and added description in test file * Removed empty lines
Resolves #679