Rollback 3187 #3248
Merged
Rollback 3187 #3248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frzifus
reviewed
Aug 30, 2024
|
|
||
| # One or more tracking issues related to the change | ||
| issues: [3160] | ||
| issues: [3242] |
There was a problem hiding this comment.
I think it would make sense to create a new changelog entry for the rollback.
There was a problem hiding this comment.
Thanks, I'm unfamiliar with the process. I think I've done it correctly now, but let me know if I missed something.
foolusion
force-pushed
the
fix-3242-rollback-of-3187
branch
from
158dd00 to
d4516e2
Compare
|
this lgtm @foolusion can you resolve the conflicts so we can merge this prior to release? |
# Conflicts: # controllers/builder_test.go
foolusion
force-pushed
the
fix-3242-rollback-of-3187
branch
from
d4516e2 to
b065f91
Compare
|
👍 Done |
swiatekm
approved these changes
Sep 5, 2024
| component: target allocator | ||
|
|
||
| # A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`). | ||
| note: Rollback 3187 |
There was a problem hiding this comment.
We should at least do #3187, so this renders into a link to the PR in the changelog.
There was a problem hiding this comment.
Oh, I wasn't sure about that since I thought it might consider it a line comment. Looks like it already got merged.
jaronoff97
approved these changes
Sep 5, 2024
|
thank you for your contribution 🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Rollback #3187
Fix #3242 with rollback of 3187. Please make sure this change works for clusters with custom domains before re submitting.
Link to tracking Issue(s): #3242
Testing: This rolls back to previously working code.
Documentation: None