Fix TA in clusters with global proxy #3187

pavolloffay · 2024-07-31T13:17:26Z

Operator image: docker.io/pavolloffay/opentelemetry-operator:dev-b67d063e-1722432504

Description:

See the changelog for more info.

On clusters with global proxy following error was happening on the collector

2024-07-22T21:11:58.189Z       info    [[email protected]/service.go:113](mailto:[email protected]/service.go:113)       Setting up own telemetry...

2024-07-22T21:11:58.189Z       info    [[email protected]/telemetry.go:96](mailto:[email protected]/telemetry.go:96)      Serving metrics {"address": ":8888", "level": "Normal"}

2024-07-22T21:11:58.189Z       info    [[email protected]/exporter.go:275](mailto:[email protected]/exporter.go:275)     Development component. May change in the future.  {"kind": "exporter", "data_type": "metrics", "name": "debug"}

2024-07-22T21:11:58.191Z       info    [[email protected]/service.go:180](mailto:[email protected]/service.go:180)       Starting otelcol...     {"Version": "0.102.1", "NumCPU": 12}

2024-07-22T21:11:58.191Z       info    extensions/extensions.go:34    Starting extensions...

2024-07-22T21:11:58.191Z       info        [[email protected]/metrics_receiver.go:279](mailto:[email protected]/metrics_receiver.go:279)   Starting discovery manager        {"kind": "receiver", "name": "prometheus", "data_type": "metrics"}

2024-07-22T21:11:58.192Z       info        [[email protected]/metrics_receiver.go:121](mailto:[email protected]/metrics_receiver.go:121)   Starting target allocator discovery      {"kind": "receiver", "name": "prometheus", "data_type": "metrics"}

2024-07-22T21:11:58.265Z       error        [[email protected]/metrics_receiver.go:154](mailto:[email protected]/metrics_receiver.go:154)   Failed to retrieve job list        {"kind": "receiver", "name": "prometheus", "data_type": "metrics", "error": "yaml: line 6: mapping values are not allowed in this context"}

[github.com/open-telemetry/opentelemetry-collector-contrib/receiver/prometheusreceiver.(*pReceiver).syncTargetAllocator](http://github.com/open-telemetry/opentelemetry-collector-contrib/receiver/prometheusreceiver.(*pReceiver).syncTargetAllocator)

        [github.com/open-telemetry/opentelemetry-collector-contrib/receiver/[email protected]/metrics_receiver.go:154](mailto:github.com/open-telemetry/opentelemetry-collector-contrib/receiver/[email protected]/metrics_receiver.go:154)

[github.com/open-telemetry/opentelemetry-collector-contrib/receiver/prometheusreceiver.(*pReceiver).startTargetAllocator](http://github.com/open-telemetry/opentelemetry-collector-contrib/receiver/prometheusreceiver.(*pReceiver).startTargetAllocator)

        [github.com/open-telemetry/opentelemetry-collector-contrib/receiver/[email protected]/metrics_receiver.go:123](mailto:github.com/open-telemetry/opentelemetry-collector-contrib/receiver/[email protected]/metrics_receiver.go:123)

[github.com/open-telemetry/opentelemetry-collector-contrib/receiver/prometheusreceiver.(*pReceiver).Start](http://github.com/open-telemetry/opentelemetry-collector-contrib/receiver/prometheusreceiver.(*pReceiver).Start)

        [github.com/open-telemetry/opentelemetry-collector-contrib/receiver/[email protected]/metrics_receiver.go:107](mailto:github.com/open-telemetry/opentelemetry-collector-contrib/receiver/[email protected]/metrics_receiver.go:107)

[go.opentelemetry.io/collector/service/internal/graph.(*Graph).StartAll](http://go.opentelemetry.io/collector/service/internal/graph.(*Graph).StartAll)

        [go.opentelemetry.io/collector/[email protected]/internal/graph/graph.go:421](mailto:go.opentelemetry.io/collector/[email protected]/internal/graph/graph.go:421)

[go.opentelemetry.io/collector/service.(*Service).Start](http://go.opentelemetry.io/collector/service.(*Service).Start)

        [go.opentelemetry.io/collector/[email protected]/service.go:198](mailto:go.opentelemetry.io/collector/[email protected]/service.go:198)

[go.opentelemetry.io/collector/otelcol.(*Collector).setupConfigurationComponents](http://go.opentelemetry.io/collector/otelcol.(*Collector).setupConfigurationComponents)

        [go.opentelemetry.io/collector/[email protected]/collector.go:223](mailto:go.opentelemetry.io/collector/[email protected]/collector.go:223)

[go.opentelemetry.io/collector/otelcol.(*Collector).Run](http://go.opentelemetry.io/collector/otelcol.(*Collector).Run)

        [go.opentelemetry.io/collector/[email protected]/collector.go:277](mailto:go.opentelemetry.io/collector/[email protected]/collector.go:277)

[go.opentelemetry.io/collector/otelcol.NewCommand.func1](http://go.opentelemetry.io/collector/otelcol.NewCommand.func1)

        [go.opentelemetry.io/collector/[email protected]/command.go:35](mailto:go.opentelemetry.io/collector/[email protected]/command.go:35)

[github.com/spf13/cobra.(*Command).execute](http://github.com/spf13/cobra.(*Command).execute)

        [github.com/spf13/[email protected]/command.go:983](mailto:github.com/spf13/[email protected]/command.go:983)

[github.com/spf13/cobra.(*Command).ExecuteC](http://github.com/spf13/cobra.(*Command).ExecuteC)

        [github.com/spf13/[email protected]/command.go:1115](mailto:github.com/spf13/[email protected]/command.go:1115)

[github.com/spf13/cobra.(*Command).Execute](http://github.com/spf13/cobra.(*Command).Execute)

        [github.com/spf13/[email protected]/command.go:1039](mailto:github.com/spf13/[email protected]/command.go:1039)

main.runInteractive

        [github.com/os-observability/redhat-opentelemetry-collector/main.go:53](http://github.com/os-observability/redhat-opentelemetry-collector/main.go:53)

main.run

        [github.com/os-observability/redhat-opentelemetry-collector/main_others.go:10](http://github.com/os-observability/redhat-opentelemetry-collector/main_others.go:10)

main.main

        [github.com/os-observability/redhat-opentelemetry-collector/main.go:46](http://github.com/os-observability/redhat-opentelemetry-collector/main.go:46)

runtime.main

        runtime/proc.go:271

2024-07-22T21:11:58.265Z       info    [[email protected]/service.go:243](mailto:[email protected]/service.go:243)       Starting shutdown...

2024-07-22T21:11:58.265Z       info    extensions/extensions.go:59    Stopping extensions...

2024-07-22T21:11:58.265Z       info    [[email protected]/service.go:257](mailto:[email protected]/service.go:257)       Shutdown complete.

Error: cannot start pipelines: yaml: line 6: mapping values are not allowed in this context

2024/07/22 21:11:58 collector server run finished with error: cannot start pipelines: yaml: line 6: mapping values are not allowed in this context

Link to tracking Issue(s):

Resolves: #issue-number

Testing:

Documentation:

Signed-off-by: Pavol Loffay <[email protected]>

pavolloffay · 2024-07-31T13:59:12Z

tests/e2e-targetallocator/targetallocator-kubernetessd/chainsaw-test.yaml

@@ -5,6 +5,7 @@ metadata:
  creationTimestamp: null
  name: targetallocator-kubernetessd
 spec:
+  namespace: chainsaw-targetallocator-kubernetessd


Switching to using the static nemaspaces for the tests that assert collector config map with TA endpoint (now it contains namespace).

We will be able to get rid of this once we migrate to v1beta1 and use the namespace substitution provided by chainsaw.

jaronoff97 · 2024-07-31T14:23:03Z

internal/manifests/targetallocator/adapters/config_to_prom_config_test.go

@@ -279,15 +279,15 @@ func TestAddHTTPSDConfigToPromConfig(t *testing.T) {
 						"job_name": "test_job",
 						"http_sd_configs": []interface{}{
 							map[string]interface{}{
-								"url": fmt.Sprintf("http://%s:80/jobs/%s/targets?collector_id=$POD_NAME", taServiceName, url.QueryEscape("test_job")),
+								"url": fmt.Sprintf("http://%s.default.svc.cluster.local:80/jobs/%s/targets?collector_id=$POD_NAME", taServiceName, url.QueryEscape("test_job")),


i think this should always work... do we have any concerns around custom DNS resolvers? i guess this would probably fail today for those use cases, but want to be sure this couldn't possibly break a user.

I am not sure I follow you. Could you please explain more how this fix could break uses with custom DNS resolver?

Using default.svc.cluster.local is pretty standard on k8s.

yes, i guess my concern is for users with custom DNS policies set https://kubernetes.io/docs/concepts/services-networking/dns-pod-service/#pod-dns-config. I think i'm being overly cautious.

foolusion · 2024-08-28T17:39:47Z

I believe this change breaks us. Why is this hardcoded as svc.cluster.local. I assume many people use custom cluster-domain.

jaronoff97 · 2024-08-28T17:53:37Z

@foolusion sorry to hear that, would you be able to open a new issue explaining the bug you're running into?

Fix TA in clusters with global proxy

00739ed

Signed-off-by: Pavol Loffay <[email protected]>

pavolloffay requested a review from a team July 31, 2024 13:17

pavolloffay added 2 commits July 31, 2024 15:21

Add chlog

b67d063

Signed-off-by: Pavol Loffay <[email protected]>

Fix e2e chlog

2847621

Signed-off-by: Pavol Loffay <[email protected]>

pavolloffay commented Jul 31, 2024

View reviewed changes

jaronoff97 reviewed Jul 31, 2024

View reviewed changes

pavolloffay mentioned this pull request Jul 31, 2024

Release the operator v0.106.0 #3183

Closed

jaronoff97 approved these changes Jul 31, 2024

View reviewed changes

pavolloffay merged commit b20fbd5 into open-telemetry:main Aug 5, 2024
33 checks passed

This was referenced Aug 29, 2024

TargetAllocator broken after release 0.105 when using custom domains. #3242

Closed

Rollback 3187 #3248

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix TA in clusters with global proxy #3187

Fix TA in clusters with global proxy #3187

pavolloffay commented Jul 31, 2024 •

edited

Loading

pavolloffay Jul 31, 2024

jaronoff97 Jul 31, 2024

pavolloffay Jul 31, 2024

jaronoff97 Jul 31, 2024

foolusion commented Aug 28, 2024

jaronoff97 commented Aug 28, 2024

Fix TA in clusters with global proxy #3187

Fix TA in clusters with global proxy #3187

Conversation

pavolloffay commented Jul 31, 2024 • edited Loading

pavolloffay Jul 31, 2024

Choose a reason for hiding this comment

jaronoff97 Jul 31, 2024

Choose a reason for hiding this comment

pavolloffay Jul 31, 2024

Choose a reason for hiding this comment

jaronoff97 Jul 31, 2024

Choose a reason for hiding this comment

foolusion commented Aug 28, 2024

jaronoff97 commented Aug 28, 2024

pavolloffay commented Jul 31, 2024 •

edited

Loading