Fix ClusterRole and ClusterRoleBinding reconciliation #2526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swiatekm
force-pushed
the
fix/clusterrole-permissions
branch
4 times, most recently
from
0df1f85 to
201287c
Compare
swiatekm
changed the title
swiatekm
force-pushed
the
fix/clusterrole-permissions
branch
from
201287c to
6cd85c8
Compare
jaronoff97
approved these changes
Jan 17, 2024
TylerHelmuth
approved these changes
Jan 17, 2024
ItielOlenick
pushed a commit
to ItielOlenick/opentelemetry-operator
that referenced
this pull request
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Only reconcile ClusterRoles and ClusterRoleBindings if the
--create-rbac-permissionsflag is set.Link to tracking Issue: #2525
Testing:
I removed the permissions from default manifests, so existing tests cover the change.