Operator won't reconcile without CRUD permissions for ClusterRoles and Bindings

[swiatekm]

Component(s)

operator

What happened?

Description

#2394 was supposed to require permissions for ClusterRoles only if the command-line flag was enabled. However, we try to reconcile the resources unconditionally here:

opentelemetry-operator/controllers/opentelemetrycollector_controller.go

Line 145 in 7dc743f

Owns(&rbacv1.ClusterRoleBinding{}).

. This should be conditional. As is, the change is unintentionally breaking.

Steps to Reproduce

@TylerHelmuth noticed this while upgrading operator version in the Helm Chart: open-telemetry/opentelemetry-helm-charts#998. We didn't notice because we added these permissions to our cluster role in kustomize manifests.

Expected Result

Operator should reconcile resources without these permissions if the command-line flag wasn't set.

Kubernetes Version

1.24

Operator version

0.92.0

Collector version

0.92.0

Environment information

Environment

OS: (e.g., "Ubuntu 20.04")
Compiler(if manually compiled): (e.g., "go 14.2")

Log output

No response

Additional context

No response

[swiatekm]

Fixed in #2526.