Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add default appProtocol on oc receiver #2486

Merged
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions .chloggen/main.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
change_type: bug_fix

# The name of the component, or a single word describing the area of concern, (e.g. operator, target allocator, github action)
component: operator

# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
note: add missing appProtocol in opencensus receiver

# One or more tracking issues related to the change
issues: []
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to put your issue number here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added, thanks.


# (Optional) One or more lines of additional information to render under the primary note.
# These lines will be padded with 2 spaces and then inserted directly into the document.
# Use pipe (|) for multiline entries.
subtext:
12 changes: 7 additions & 5 deletions internal/manifests/collector/parser/receiver/receiver_oc.go
Original file line number Diff line number Diff line change
Expand Up @@ -24,12 +24,14 @@

// NewOpenCensusReceiverParser builds a new parser for OpenCensus receivers.
func NewOpenCensusReceiverParser(logger logr.Logger, name string, config map[interface{}]interface{}) parser.ComponentPortParser {
http := "http"

Check failure on line 27 in internal/manifests/collector/parser/receiver/receiver_oc.go

View workflow job for this annotation

GitHub Actions / Code standards (linting)

shadow: declaration of "http" shadows declaration at line 39 (govet)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How to fix this one @swiatekm-sumo?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to change the variable name, to httpAppProtocol for example.

return &GenericReceiver{
logger: logger,
name: name,
config: config,
defaultPort: 55678,
parserName: parserNameOpenCensus,
logger: logger,
name: name,
config: config,
defaultPort: 55678,
parserName: parserNameOpenCensus,
defaultAppProtocol: &http,
}
}

Expand Down
Loading