feat: add default appProtocol on oc receiver #2486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Husni Alhamdani <[email protected]>
swiatekm
reviewed
Jan 4, 2024
.chloggen/main.yaml
Outdated
| note: add missing appProtocol in opencensus receiver | ||
|
|
||
| # One or more tracking issues related to the change | ||
| issues: [] |
There was a problem hiding this comment.
You need to put your issue number here.
Signed-off-by: Husni Alhamdani <[email protected]>
husnialhamdani
commented
Jan 4, 2024
| @@ -24,12 +24,14 @@ const parserNameOpenCensus = "__opencensus" | |||
|
|
|||
| // NewOpenCensusReceiverParser builds a new parser for OpenCensus receivers. | |||
| func NewOpenCensusReceiverParser(logger logr.Logger, name string, config map[interface{}]interface{}) parser.ComponentPortParser { | |||
| http := "http" | |||
There was a problem hiding this comment.
How to fix this one @swiatekm-sumo?
There was a problem hiding this comment.
You need to change the variable name, to httpAppProtocol for example.
Signed-off-by: Husni Alhamdani <[email protected]>
swiatekm
approved these changes
Jan 4, 2024
jaronoff97
approved these changes
Jan 4, 2024
6 tasks
ItielOlenick
pushed a commit
to ItielOlenick/opentelemetry-operator
that referenced
this pull request
May 1, 2024
* feat: add default appProtocol on oc receiver Signed-off-by: Husni Alhamdani <[email protected]> * feat: add default appProtocol on oc receiver Signed-off-by: Husni Alhamdani <[email protected]> * feat: add default appProtocol on oc receiver Signed-off-by: Husni Alhamdani <[email protected]> --------- Signed-off-by: Husni Alhamdani <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
add missing appProtocol in opencensus receiver
Link to tracking Issue: #2487
Testing:
Documentation: