Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Update Instrumentation example with python env var #1330

Merged
merged 2 commits into from
Jan 9, 2023
Merged

[chore] Update Instrumentation example with python env var #1330

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
104239a
Update Instrumentation example with python env var
TylerHelmuth Dec 15, 2022
70fb9c1
Add comment
TylerHelmuth Dec 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,6 +196,10 @@ spec:
sampler:
type: parentbased_traceidratio
argument: "0.25"
python:
env:
- name: OTEL_EXPORTER_OTLP_ENDPOINT
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this deserves a comment (for us but as well for the users) to explain why this needs to be overridden.

There are as well other references in the code related to this issue:

opentelemetry-operator/autoinstrumentation/python/requirements.txt

Line 2 in 2ea988c

# We don't use the distro[otlp] option which automatically includes exporters since gRPC is not appropriate for

opentelemetry-operator/pkg/instrumentation/python.go

Line 60 in 992b681

// Set OTEL_TRACES_EXPORTER to HTTP exporter if not set by user because it is what our autoinstrumentation supports.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a comment

value: http://otel-collector:4318
EOF
```

Expand Down