[chore] Update Instrumentation example with python env var #1330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavolloffay
reviewed
Dec 19, 2022
| @@ -196,6 +196,10 @@ spec: | |||
| sampler: | |||
| type: parentbased_traceidratio | |||
| argument: "0.25" | |||
| python: | |||
| env: | |||
| - name: OTEL_EXPORTER_OTLP_ENDPOINT | |||
There was a problem hiding this comment.
I think this deserves a comment (for us but as well for the users) to explain why this needs to be overridden.
There are as well other references in the code related to this issue:
pavolloffay
approved these changes
Jan 9, 2023
ItielOlenick
pushed a commit
to ItielOlenick/opentelemetry-operator
that referenced
this pull request
May 1, 2024
…metry#1330) * Update Instrumentation example with python env var * Add comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #924
Updates the README's Instrumentation object to explicitly set python's OTEL_EXPORTER_OTLP_ENDPOINT value to 4318.
If we want we can also update the python injection to update any existing OTEL_EXPORTER_OTLP_ENDPOINT value to be
4318so that this distinction isn't necessary, but I think that change needs some scrutiny to make sure users can still configure anything they want with confidence that we aren't messing with it.