Add scrape configs endpoint #1124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto 1106-default-settings-prometheus-cr
jaronoff97
commented
Sep 28, 2022
jaronoff97
commented
Sep 28, 2022
jaronoff97
commented
Sep 28, 2022
pavolloffay
requested changes
Sep 29, 2022
secustor
reviewed
Sep 29, 2022
jaronoff97
requested review from
kristinapathak,
secustor and
Aneurysm9
and removed request for
kristinapathak and
secustor
6 tasks
secustor
approved these changes
Oct 1, 2022
Aneurysm9
approved these changes
Oct 3, 2022
Co-authored-by: Anthony Mirabella <[email protected]>
pavolloffay
approved these changes
Oct 4, 2022
ItielOlenick
pushed a commit
to ItielOlenick/opentelemetry-operator
that referenced
this pull request
May 1, 2024
* Add scrape configs endpoint * Fix a borked chan * Fix some defaults * comments and cleaning * Goimports * Pass linting * Reuse and docs * Update pkg/collector/container.go Co-authored-by: Anthony Mirabella <[email protected]> Co-authored-by: Pavol Loffay <[email protected]> Co-authored-by: Anthony Mirabella <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the first one needed in order to close #1106. We add a new endpoint which exposes the scrape configs that the target allocator has access to both from its configmap and also from prometheus CRDs.
A followup PR will be made in collector contrib to start using the endpoint.