Use the new scrape config endpoint for the prometheus receiver #14464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaronoff97
changed the title
6 tasks
moh-osman3
reviewed
Oct 3, 2022
moh-osman3
reviewed
Oct 3, 2022
…contrib into 1106-use-scrape-configs-endpoint
dashpole
reviewed
Oct 4, 2022
dashpole
reviewed
Oct 4, 2022
dashpole
reviewed
Oct 4, 2022
dashpole
approved these changes
Oct 4, 2022
dashpole
added
ready to merge
codeboten
approved these changes
Oct 6, 2022
shalper2
pushed a commit
to shalper2/opentelemetry-collector-contrib
that referenced
this pull request
Dec 6, 2022
…telemetry#14464) This fixes issue 1106 in the operator which relates to the collector failing to get scrape config jobs from the target allocator. Before this is merged this pr needs to be merged which adds this new endpoint.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR fixes issue 1106 in the operator which relates to the collector failing to get scrape config jobs from the target allocator. Before this is merged this pr needs to be merged which adds this new endpoint.
Link to tracking Issue:
open-telemetry/opentelemetry-operator#1106
Testing:
This was tested by running a custom collector in a kubernetes cluster with the changes in the operator and target allocator. You can see the collector pulling expected jobs from the target allocator here.
Documentation:
Closes #14597