This repository has been archived by the owner on May 25, 2022. It is now read-only.
Add double-star mutli-level directory glob matching to filelog receiver #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djaglowski
reviewed
Apr 12, 2021
There was a problem hiding this comment.
Looks good, just a couple minor suggestions.
Could you also update the file_input documentation so that users can easily find the exact rules that govern paths. It's ok to directly reference the doublestar docs. This is done elsewhere, such as in the expressions doc.
pmalek-sumo
force-pushed
the
issue-2329-add-double-star-glob-matching-to-filelog
branch
from
0cb95f5 to
e3e9e08
Compare
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: open-telemetry/opentelemetry-collector-contrib#2329