Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port doublestar support from Opentelementry #283

Merged
merged 9 commits into from
May 7, 2021
Merged

Conversation

Mrod1598
Copy link
Contributor

Description of Changes

Ported double star support from this PR: open-telemetry/opentelemetry-log-collection#97

Please check that the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • [N/A] Docs have been added / updated (for bug fixes / features)
  • Add a changelog entry (for non-trivial bug fixes / features)
  • CI passes

@Mrod1598 Mrod1598 changed the title Port doublestar support from stanza Port doublestar support from Opentelementry Apr 23, 2021
@djaglowski
Copy link
Member

Log Files Logs / Second CPU Avg (%) CPU Avg Δ (%) Memory Avg (MB) Memory Avg Δ (MB)
1 1000 1.534483 +0.18957639 127.35385 +3.6251373
1 5000 5.3448853 +0.051736355 133.01616 +0.17201233
1 10000 10.41405 +0.103425026 139.49799 +0.69181824
1 50000 50.778046 +0.018699646 167.6029 -5.872177
1 100000 99.77845 +1.5515213 231.1879 -8.694916
10 100 1.9138571 -0.017189503 132.28125 +2.0585938
10 500 6.0863123 -0.18959236 135.25296 -1.1895294
10 1000 12.361867 +0.12033367 144.24785 +3.0735474
10 5000 57.087273 +1.205513 180.96713 -2.8376923
10 10000 109.52928 +2.5329819 239.00781 +24.011444

@djaglowski
Copy link
Member

Log Files Logs / Second CPU Avg (%) CPU Avg Δ (%) Memory Avg (MB) Memory Avg Δ (MB)
1 1000 1.6034076 +0.25850105 124.155304 +0.42658997
1 5000 5.3794465 +0.08629751 132.43454 -0.40960693
1 10000 10.568939 +0.25831413 140.79202 +1.9858551
1 50000 52.10032 +1.3409729 175.46133 +1.9862518
1 100000 100.76027 +2.5333405 236.52519 -3.3576202
10 100 2.0345914 +0.10354483 128.08984 -2.1328125
10 500 6.172491 -0.10341358 140.71632 +4.273834
10 1000 11.982997 -0.25853634 142.9441 +1.7698059
10 5000 55.10537 -0.7763901 180.51833 -3.286499
10 10000 107.68722 +0.69091797 219.60062 +4.604248

@codecov
Copy link

codecov bot commented Apr 23, 2021

Codecov Report

Merging #283 (756cbe0) into master (63883bc) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #283      +/-   ##
==========================================
+ Coverage   70.60%   70.65%   +0.05%     
==========================================
  Files         112      112              
  Lines        5970     5970              
==========================================
+ Hits         4215     4218       +3     
+ Misses       1311     1307       -4     
- Partials      444      445       +1     
Impacted Files Coverage Δ
operator/builtin/input/file/config.go 79.57% <100.00%> (ø)
operator/builtin/input/file/file.go 76.03% <100.00%> (ø)
operator/flusher/flusher.go 84.00% <0.00%> (-4.00%) ⬇️
operator/builtin/output/newrelic/newrelic.go 71.03% <0.00%> (-0.93%) ⬇️
operator/builtin/output/forward/forward.go 56.52% <0.00%> (+1.45%) ⬆️
operator/builtin/input/tcp/tcp.go 71.43% <0.00%> (+4.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63883bc...756cbe0. Read the comment docs.

@jsirianni jsirianni self-requested a review April 27, 2021 18:12
Copy link
Member

@jsirianni jsirianni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this is necessary, but we might want to add the open telemetry license header to source files when porting code from https://github.com/open-telemetry/opentelemetry-log-collection.

@Mrod1598
Copy link
Contributor Author

Mrod1598 commented Apr 30, 2021

Not sure if this is necessary, but we might want to add the open telemetry license header to source files when porting code from https://github.com/open-telemetry/opentelemetry-log-collection.

so even if it is just a small change like this? or is there someway we can specify that only a few parts were related to opentelemetry

@djaglowski
Copy link
Member

#292 addresses copyright concerns. Thank you for pointing out @jsirianni

@jsirianni jsirianni self-requested a review May 6, 2021 19:59
@djaglowski
Copy link
Member

Log Files Logs / Second CPU Avg (%) CPU Avg Δ (%) Memory Avg (MB) Memory Avg Δ (MB)
1 1000 1.6551952 +0.068978906 124.751076 +3.131462
1 5000 5.741674 +0.655262 133.80968 +0.39575195
1 10000 10.138069 -0.2932968 139.90504 +0.09187317
1 50000 51.926624 +3.3225098 174.4243 +2.6632538
1 100000 97.3814 +0.8339386 236.06789 +0.7369385
10 100 2.241465 +0.13796997 131.87271 +3.7555237
10 500 6.103522 +0.29299545 136.39763 +0.20932007
10 1000 12.051995 -0.22407818 139.33083 -2.4865265
10 5000 56.51952 -2.535801 180.40504 +0.96754456
10 10000 108.46549 -0.98218536 228.70865 -2.545395

@djaglowski
Copy link
Member

Log Files Logs / Second CPU Avg (%) CPU Avg Δ (%) Memory Avg (MB) Memory Avg Δ (MB)
1 1000 1.4827728 -0.051727533 126.6052 +2.1615067
1 5000 5.3277373 +0.03461027 132.89952 +0.9758911
1 10000 10.672528 +0.29315758 140.38066 -0.40396118
1 50000 50.394012 +1.2207146 171.01064 -1.8215332
1 100000 88.44986 -12.444885 225.09793 -16.194763
10 100 1.913848 -0.10343349 132.4072 +2.2861023
10 500 6.172457 -0.2927189 136.59833 +1.7062225
10 1000 11.827892 -0.3274765 143.47293 -0.7196808
10 5000 56.36355 +1.0247955 183.4255 +2.0009308
10 10000 106.77963 +1.4495544 227.65585 +14.460678

@Mrod1598 Mrod1598 merged commit 732753b into master May 7, 2021
@jsirianni jsirianni deleted the add-double-star branch May 7, 2021 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants