Skip to content
This repository has been archived by the owner on May 25, 2022. It is now read-only.

CSV Idiomatic Errors #323

Merged
merged 2 commits into from
Dec 20, 2021
Merged

Conversation

cpheps
Copy link
Contributor

@cpheps cpheps commented Dec 2, 2021

  • Changed errors in CSV parser operator to have lowercase first words to be idiomatic.
  • Removed some fmt.Errorf in favor of errors.New where formatting wasn't needed to create error

@cpheps cpheps requested a review from a team December 2, 2021 17:32
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Dec 2, 2021

CLA Signed

The committers are authorized under a signed CLA.

@jsirianni jsirianni self-requested a review December 2, 2021 17:38
@jsirianni
Copy link
Member

@cpheps Let me know when CLA is handled and I will trigger CI 👍

@cpheps
Copy link
Contributor Author

cpheps commented Dec 2, 2021

@jsirianni will do. @djaglowski is working on getting me signed up I'll follow up with you when that's done.

Copy link
Member

@djaglowski djaglowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but waiting on EasyCLA approval

@codecov
Copy link

codecov bot commented Dec 20, 2021

Codecov Report

Merging #323 (560c9fc) into main (d86516e) will decrease coverage by 0.1%.
The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #323     +/-   ##
=======================================
- Coverage   77.0%   76.9%   -0.2%     
=======================================
  Files         94      94             
  Lines       4410    4410             
=======================================
- Hits        3400    3395      -5     
- Misses       695     698      +3     
- Partials     315     317      +2     
Impacted Files Coverage Δ
operator/builtin/parser/csv/csv.go 97.3% <100.0%> (ø)
operator/builtin/input/file/file.go 72.3% <0.0%> (-1.9%) ⬇️
operator/builtin/input/tcp/tcp.go 78.0% <0.0%> (-1.7%) ⬇️

@djaglowski djaglowski merged commit fa36116 into open-telemetry:main Dec 20, 2021
@djaglowski djaglowski deleted the csv-idomatic-errors branch December 20, 2021 15:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants