CSV Idiomatic Errors (#323)

* Changed errors in csv operator to have lowercase first word to be idiomatic Signed-off-by: Corbin Phelps <[email protected]> * Removed fmt.Errorf in csv for errors that did not require formatting Signed-off-by: Corbin Phelps <[email protected]>
open-telemetry · Dec 20, 2021 · fa36116 · fa36116
1 parent d79bfca
commit fa36116
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/operator/builtin/parser/csv/csv.go b/operator/builtin/parser/csv/csv.go
@@ -16,6 +16,7 @@ package csv
 import (
 	"context"
 	csvparser "encoding/csv"
+	"errors"
 	"fmt"
 	"strings"
 
@@ -52,21 +53,21 @@ func (c CSVParserConfig) Build(context operator.BuildContext) ([]operator.Operat
 	}
 
 	if c.Header == "" {
-		return nil, fmt.Errorf("Missing required field 'header'")
+		return nil, errors.New("missing required field 'header'")
 	}
 
 	if c.FieldDelimiter == "" {
 		c.FieldDelimiter = ","
 	}
 
 	if len([]rune(c.FieldDelimiter)) != 1 {
-		return nil, fmt.Errorf("Invalid 'delimiter': '%s'", c.FieldDelimiter)
+		return nil, fmt.Errorf("invalid 'delimiter': '%s'", c.FieldDelimiter)
 	}
 
 	fieldDelimiter := []rune(c.FieldDelimiter)[0]
 
 	if !strings.Contains(c.Header, c.FieldDelimiter) {
-		return nil, fmt.Errorf("missing field delimiter in header")
+		return nil, errors.New("missing field delimiter in header")
 	}
 
 	numFields := len(strings.Split(c.Header, c.FieldDelimiter))

diff --git a/operator/builtin/parser/csv/csv_test.go b/operator/builtin/parser/csv/csv_test.go
@@ -51,7 +51,7 @@ func TestCSVParserBuildFailureInvalidDelimiter(t *testing.T) {
 	cfg.FieldDelimiter = ";;"
 	_, err := cfg.Build(testutil.NewBuildContext(t))
 	require.Error(t, err)
-	require.Contains(t, err.Error(), "Invalid 'delimiter': ';;'")
+	require.Contains(t, err.Error(), "invalid 'delimiter': ';;'")
 }
 
 func TestCSVParserByteFailure(t *testing.T) {