Skip to content
This repository has been archived by the owner on May 25, 2022. It is now read-only.

Add fieldalignment tool and check #218

Merged
merged 1 commit into from
Jul 14, 2021

Conversation

pmalek-sumo
Copy link
Contributor

Tracking issue: #98

@pmalek-sumo pmalek-sumo requested a review from a team July 14, 2021 09:46
@codecov
Copy link

codecov bot commented Jul 14, 2021

Codecov Report

Merging #218 (b15a4a1) into main (2ffe032) will increase coverage by 0.0%.
The diff coverage is 100.0%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main    #218   +/-   ##
=====================================
  Coverage   75.6%   75.6%           
=====================================
  Files         95      95           
  Lines       4408    4411    +3     
=====================================
+ Hits        3334    3337    +3     
  Misses       747     747           
  Partials     327     327           
Impacted Files Coverage Δ
agent/agent.go 100.0% <ø> (ø)
agent/builder.go 91.6% <ø> (ø)
pipeline/node.go 100.0% <100.0%> (ø)

Copy link
Member

@djaglowski djaglowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. I confirmed it works locally.

What do you envision as far as managing the directories that it covers? Is there a technical reason not to include all directories? If not, should we do so?

@pmalek-sumo
Copy link
Contributor Author

I don't have a strong opinion on this. We can either take small steps or go for ./... in this PR.

If this gets a 🟢 light then I can make the required changes proposed by fieldalignment -fix ./... and add those in this PR.

@djaglowski
Copy link
Member

Thanks @pmalek-sumo. I'll merge this, and we can enhance from here.

@djaglowski djaglowski merged commit 76abfd8 into open-telemetry:main Jul 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants