Skip to content
This repository has been archived by the owner on May 25, 2022. It is now read-only.

Add fieldalignment make target #98

Closed
djaglowski opened this issue Apr 12, 2021 · 4 comments
Closed

Add fieldalignment make target #98

djaglowski opened this issue Apr 12, 2021 · 4 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@djaglowski
Copy link
Member

djaglowski commented Apr 12, 2021

See #95

It would be nice to have this functionality readily available so we can easily identify further improvements, and also so that we can easily validate that we have not regressed.

@djaglowski djaglowski changed the title Add fieldalignment make targets Add fieldalignment make target Apr 12, 2021
@djaglowski djaglowski added good first issue Good for newcomers help wanted Extra attention is needed labels Apr 20, 2021
@chasekiefer
Copy link

Do you want a specific target to run this? Otherwise I can just add the maligned linter to the .golangci.yml configuration. Maligned seems to be the golangci-lint supported version of fieldalignment.

@djaglowski
Copy link
Member Author

maligned appears to be deprecated, and suggests to use fieldalignment instead, so I think we should follow that.

I think a new make target is fine for this. The goal here is not really to aggressively push for these optimizations, but rather to ensure that when a developer chooses to optimize, they are doing so in a consistent manner.

@pmalek-sumo
Copy link
Contributor

@djaglowski Please take a look at my proposal in #218

There's more to be changed in code but I've demonstrated a gradual approach by changing just a handful of files.

@djaglowski
Copy link
Member Author

djaglowski commented Jul 14, 2021

Addressed in #218

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants