chore: updated collector to v0.36.0 #143
Conversation
willarmiros
requested review from
anuraaga,
codeboten and
wangzlei
as code owners
| @@ -2,4 +2,13 @@ module github.com/open-telemetry/opentelemetry-lambda/collector/lambdacomponents | |||
|
|
|||
| go 1.16 | |||
There was a problem hiding this comment.
Think this file's go.sum isn't updated yet
There was a problem hiding this comment.
Should be good now.
| require go.opentelemetry.io/collector v0.33.0 | ||
| require ( | ||
| go.opentelemetry.io/collector v0.36.0 | ||
| github.com/open-telemetry/opentelemetry-collector-contrib/exporter/prometheusremotewriteexporter v0.36.0 |
There was a problem hiding this comment.
Just wondering where did this list come from?
There was a problem hiding this comment.
It's based on all the components here that were no longer in the core collector: https://github.com/open-telemetry/opentelemetry-lambda/blob/main/collector/lambdacomponents/default.go#L19-L30
|
Fixed the breaking change with the new |
| @@ -5,6 +5,21 @@ go 1.16 | |||
| replace github.com/open-telemetry/opentelemetry-lambda/collector/lambdacomponents => ./lambdacomponents | |||
|
|
|||
| require ( | |||
| github.com/cespare/xxhash/v2 v2.1.2 // indirect | |||
There was a problem hiding this comment.
Is there any reason not to have these indirect imports? I noticed we were deleting them before.
There was a problem hiding this comment.
We should keep whatever go adds
| @@ -5,6 +5,21 @@ go 1.16 | |||
| replace github.com/open-telemetry/opentelemetry-lambda/collector/lambdacomponents => ./lambdacomponents | |||
|
|
|||
| require ( | |||
| github.com/cespare/xxhash/v2 v2.1.2 // indirect | |||
There was a problem hiding this comment.
We should keep whatever go adds
Updates to upstream collector v0.36.0. I was pretty confident that I should be adding the newly separated components to
collector/lambdacomponens/go.modinstead ofcollector/go.mod, but would appreciate if someone could double check.