Split Collector from the cobra.Command. #4074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @mx-psi |
mx-psi
reviewed
Sep 20, 2021
bogdandrutu
force-pushed
the
splitcommand
branch
from
60d9de6 to
afea6c2
Compare
mx-psi
approved these changes
Sep 20, 2021
Signed-off-by: Bogdan Drutu <[email protected]>
bogdandrutu
force-pushed
the
splitcommand
branch
from
afea6c2 to
124b27a
Compare
dashpole
approved these changes
Sep 20, 2021
Aneurysm9
approved these changes
Sep 20, 2021
codeboten
reviewed
Sep 20, 2021
| }, | ||
| } | ||
|
|
||
| // TODO: coalesce this code and expose this information to other components. |
There was a problem hiding this comment.
Is this TODO still needed? If so is there an issue open for it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates #3957
Signed-off-by: Bogdan Drutu [email protected]