Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add example for postgres plugin #542

Merged
merged 10 commits into from
Dec 23, 2019

Conversation

xiao-lix
Copy link
Contributor

Which problem is this PR solving?

Short description of the changes

  • Add an express app example using postgres plugin

@xiao-lix xiao-lix changed the title feat: add example for pg plugin feat: add example for postgres plugin Nov 15, 2019
@codecov-io
Copy link

codecov-io commented Nov 15, 2019

Codecov Report

Merging #542 into master will decrease coverage by 1.75%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #542      +/-   ##
==========================================
- Coverage   90.54%   88.79%   -1.76%     
==========================================
  Files         196      195       -1     
  Lines        9680     9798     +118     
  Branches      882      900      +18     
==========================================
- Hits         8765     8700      -65     
- Misses        915     1098     +183
Impacted Files Coverage Δ
packages/opentelemetry-core/test/utils/url.test.ts 50% <0%> (-50%) ⬇️
...pentelemetry-core/test/internal/validators.test.ts 50% <0%> (-50%) ⬇️
...elemetry-core/test/trace/spancontext-utils.test.ts 55.55% <0%> (-44.45%) ⬇️
...lemetry-core/test/trace/ProbabilitySampler.test.ts 56.52% <0%> (-43.48%) ⬇️
...s/opentelemetry-core/test/trace/NoopTracer.test.ts 60% <0%> (-40%) ⬇️
...s/opentelemetry-core/test/context/B3Format.test.ts 63.39% <0%> (-36.61%) ⬇️
...ges/opentelemetry-core/test/trace/NoopSpan.test.ts 63.63% <0%> (-36.37%) ⬇️
...s/opentelemetry-core/test/trace/tracestate.test.ts 65.06% <0%> (-34.94%) ⬇️
...kages/opentelemetry-metrics/test/mocks/Exporter.ts 66.66% <0%> (-33.34%) ⬇️
...ntelemetry-core/test/trace/NoRecordingSpan.test.ts 71.42% <0%> (-28.58%) ⬇️
... and 24 more

@OlivierAlbertini OlivierAlbertini added the document Documentation-related label Nov 18, 2019
Copy link
Member

@mayurkale22 mayurkale22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, added a few minor comments

examples/postgres/client.js Outdated Show resolved Hide resolved
examples/postgres/client.js Outdated Show resolved Hide resolved
examples/postgres/package.json Outdated Show resolved Hide resolved
examples/postgres/package.json Outdated Show resolved Hide resolved
examples/postgres/setupPsql.js Outdated Show resolved Hide resolved
@mayurkale22
Copy link
Member

@open-telemetry/javascript-approvers Please review and approve if looks good.

examples/postgres/README.md Outdated Show resolved Hide resolved
Copy link
Member

@OlivierAlbertini OlivierAlbertini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

examples/postgres/client.js Outdated Show resolved Hide resolved
examples/postgres/server.js Outdated Show resolved Hide resolved
xiao-lix and others added 2 commits November 26, 2019 10:21
Co-Authored-By: Olivier Albertini <[email protected]>
Co-Authored-By: Olivier Albertini <[email protected]>
@mayurkale22 mayurkale22 added the Dependency on other PR This PR can't be merged because it has dependency on other PRs label Nov 27, 2019
@mayurkale22 mayurkale22 added Merge:LGTM This PR is ready to be merged by a Maintainer (has enough valid approvals, successful build, etc.) and removed Dependency on other PR This PR can't be merged because it has dependency on other PRs labels Dec 23, 2019
@mayurkale22
Copy link
Member

The dependent PR (#501) is already merged, merging this one now. Thanks for the work!

@mayurkale22 mayurkale22 merged commit c829a9c into open-telemetry:master Dec 23, 2019
@mayurkale22 mayurkale22 added this to the Alpha v0.3.2 milestone Dec 23, 2019
pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this pull request Dec 15, 2023
martinkuba pushed a commit to martinkuba/opentelemetry-js that referenced this pull request Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
document Documentation-related Merge:LGTM This PR is ready to be merged by a Maintainer (has enough valid approvals, successful build, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

examples: provide an example for postgres plugin
6 participants