-
Notifications
You must be signed in to change notification settings - Fork 825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add example for postgres plugin #542
feat: add example for postgres plugin #542
Conversation
Codecov Report
@@ Coverage Diff @@
## master #542 +/- ##
==========================================
- Coverage 90.54% 88.79% -1.76%
==========================================
Files 196 195 -1
Lines 9680 9798 +118
Branches 882 900 +18
==========================================
- Hits 8765 8700 -65
- Misses 915 1098 +183
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, added a few minor comments
…ry-js into xiao/add-example-pg
@open-telemetry/javascript-approvers Please review and approve if looks good. |
Co-Authored-By: Daniel Dyla <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Co-Authored-By: Olivier Albertini <[email protected]>
Co-Authored-By: Olivier Albertini <[email protected]>
The dependent PR (#501) is already merged, merging this one now. Thanks for the work! |
Which problem is this PR solving?
Short description of the changes