Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples: provide an example for postgres plugin #491

Closed
mayurkale22 opened this issue Nov 5, 2019 · 4 comments · Fixed by #542
Closed

examples: provide an example for postgres plugin #491

mayurkale22 opened this issue Nov 5, 2019 · 4 comments · Fixed by #542
Assignees
Labels
document Documentation-related
Milestone

Comments

@mayurkale22
Copy link
Member

Provide a full example on how the OpenTelemetry JS library can be used to instrument postgres and export them to Jaeger/Zipkin backend using OpenTelemetry Jaeger/Zipkin exporter.

https://github.com/open-telemetry/opentelemetry-js/tree/master/packages/opentelemetry-plugin-postgres/opentelemetry-plugin-pg

@mayurkale22 mayurkale22 added good first issue Good for newcomers up-for-grabs Good for taking. Extra help will be provided by maintainers document Documentation-related labels Nov 5, 2019
@mayurkale22 mayurkale22 added this to the Alpha v0.4 milestone Nov 6, 2019
@xiao-lix
Copy link
Contributor

I can take this if it's still available. 👀

@mayurkale22 mayurkale22 removed good first issue Good for newcomers up-for-grabs Good for taking. Extra help will be provided by maintainers labels Nov 12, 2019
@dyladan
Copy link
Member

dyladan commented Nov 13, 2019

@xiao-lix idk if you have started working on this or not but the example I'm using in my local development of mysql should be fairly easy to swap out for the pg module.

https://github.com/dynatrace-oss-contrib/opentelemetry-js/tree/f99e1743fc1e8f1d9180289aea8da7d8c735b79f/examples/mysql

@dyladan
Copy link
Member

dyladan commented Nov 13, 2019

if you have not started working, I could easily modify my example to include pg as an option, the same way the examples allow Zipkin or jaeger as an option

@xiao-lix
Copy link
Contributor

@dyladan Hi, I've started working on it and almost done. May have different implementation with your example, please feel free to comment after I create the PR. Thanks. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
document Documentation-related
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants