fix: VisibilityState type for typescript >4.6 #3741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MSNev
approved these changes
Apr 18, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3741 +/- ##
==========================================
+ Coverage 93.44% 93.45% +0.01%
==========================================
Files 290 290
Lines 8845 8845
Branches 1834 1834
==========================================
+ Hits 8265 8266 +1
+ Misses 580 579 -1 |
pichlermarc
approved these changes
Apr 19, 2023
experimental/packages/sdk-logs/test/browser/export/BatchLogRecordProcessor.test.ts
Show resolved
Hide resolved
Flarna
approved these changes
Apr 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the same fix as for BatchSpanProcessor tests in #3636, but for logs.
The VisibilityState type was renamed to DocumentVisibilityState in typescript 4.6. Once typescript is updated, we should change this temporary type to DocumentVisibilityState. The reason for adding this now is because packages from this repo are merged into the sandbox repo which uses a newer version of typescript.