Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: batchspanprocessor.test for TS > 4.6.0 #3636

Merged
merged 1 commit into from
Feb 27, 2023

Conversation

MSNev
Copy link
Contributor

@MSNev MSNev commented Feb 27, 2023

Which problem is this PR solving?

The BatchSpanProcessor.test.ts is using the type VisibilityState, this was removed from TypeScript v4.6.0+

As part of merging the JS and Contrib repo's to the web js sandbox, which is using a later version of TypeScript this test fails to build. The sandbox also attempts to run all tests in node, browser and web worker automatically as part of merging.

This change is required so that the code can be successfully merged to the sandbox.

@MSNev MSNev requested a review from a team February 27, 2023 19:35
@MSNev MSNev force-pushed the MSNev/VisibilityState branch from 6c9f892 to 8f151a8 Compare February 27, 2023 19:45
@MSNev MSNev marked this pull request as draft February 27, 2023 19:46
@MSNev MSNev marked this pull request as ready for review February 27, 2023 19:49
@codecov
Copy link

codecov bot commented Feb 27, 2023

Codecov Report

Merging #3636 (c15a11e) into main (1fbc828) will increase coverage by 0.35%.
The diff coverage is 0.00%.

❗ Current head c15a11e differs from pull request most recent head 8f151a8. Consider uploading reports for the commit 8f151a8 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3636      +/-   ##
==========================================
+ Coverage   93.89%   94.24%   +0.35%     
==========================================
  Files         265      247      -18     
  Lines        7371     6327    -1044     
  Branches     1497     1282     -215     
==========================================
- Hits         6921     5963     -958     
+ Misses        450      364      -86     
Impacted Files Coverage Δ
...ckages/opentelemetry-core/src/utils/environment.ts 92.30% <0.00%> (ø)
.../packages/api-logs/src/platform/node/globalThis.ts 0.00% <0.00%> (-100.00%) ⬇️
...-trace-base/src/platform/node/RandomIdGenerator.ts 87.50% <0.00%> (-6.25%) ⬇️
...metry-instrumentation-grpc/src/grpc/serverUtils.ts
...y-instrumentation-grpc/src/enums/AttributeNames.ts
...-instrumentation-grpc/src/enums/AttributeValues.ts
...es/opentelemetry-instrumentation-grpc/src/utils.ts
...ntelemetry-instrumentation-grpc/src/status-code.ts
...metry-instrumentation-grpc/src/grpc/clientUtils.ts
...emetry-instrumentation-grpc/src/instrumentation.ts
... and 11 more

@dyladan dyladan merged commit 708afd0 into open-telemetry:main Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants