feat(console-metric-exporter): add temporality configuration #3387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3387 +/- ##
==========================================
+ Coverage 92.43% 93.26% +0.82%
==========================================
Files 240 247 +7
Lines 6871 7346 +475
Branches 1422 1512 +90
==========================================
+ Hits 6351 6851 +500
+ Misses 520 495 -25
|
pichlermarc
force-pushed
the
feature/console-metrics-exporter-temp
branch
from
dc45af9 to
5e6d2ff
Compare
pichlermarc
force-pushed
the
feature/console-metrics-exporter-temp
branch
from
5e6d2ff to
d914b4b
Compare
pichlermarc
commented
Nov 7, 2022
Comment on lines
47
to
114
| describe('export', () => { | ||
| let previousConsoleDir: any; | ||
| let exporter: ConsoleMetricExporter; | ||
| let meterProvider: MeterProvider; | ||
| let meterReader: PeriodicExportingMetricReader; | ||
| let meter: metrics.Meter; | ||
|
|
||
| beforeEach(() => { | ||
| previousConsoleDir = console.dir; | ||
| console.dir = () => {}; | ||
|
|
||
| exporter = new ConsoleMetricExporter(); | ||
| meterProvider = new MeterProvider({ resource: defaultResource }); | ||
| meter = meterProvider.getMeter('ConsoleMetricExporter', '1.0.0'); | ||
| meterReader = new PeriodicExportingMetricReader({ | ||
| exporter: exporter, | ||
| exportIntervalMillis: 100, | ||
| exportTimeoutMillis: 100 | ||
| }); | ||
| meterProvider.addMetricReader(meterReader); | ||
| }); | ||
| meterProvider.addMetricReader(meterReader); | ||
| }); | ||
|
|
||
| afterEach(async () => { | ||
| console.dir = previousConsoleDir; | ||
| afterEach(async () => { | ||
| console.dir = previousConsoleDir; | ||
|
|
||
| await meterReader.shutdown(); | ||
| }); | ||
|
|
||
| it('should export information about metric', async () => { | ||
| const counter = meter.createCounter('counter_total', { | ||
| description: 'a test description', | ||
| }); | ||
| const counterAttribute = { key1: 'attributeValue1' }; | ||
| counter.add(10, counterAttribute); | ||
| counter.add(10, counterAttribute); | ||
|
|
||
| const histogram = meter.createHistogram('histogram', { description: 'a histogram' }); | ||
| histogram.record(10); | ||
| histogram.record(100); | ||
| histogram.record(1000); | ||
|
|
||
| const spyConsole = sinon.spy(console, 'dir'); | ||
| const spyExport = sinon.spy(exporter, 'export'); | ||
|
|
||
| await waitForNumberOfExports(spyExport, 1); | ||
| const resourceMetrics = spyExport.args[0]; | ||
| const firstResourceMetric = resourceMetrics[0]; | ||
| const consoleArgs = spyConsole.args[0]; | ||
| const consoleMetric = consoleArgs[0]; | ||
| const keys = Object.keys(consoleMetric).sort().join(','); | ||
|
|
||
| await meterReader.shutdown(); | ||
| const expectedKeys = [ | ||
| 'dataPointType', | ||
| 'dataPoints', | ||
| 'descriptor', | ||
| ].join(','); | ||
|
|
||
| assert.ok(firstResourceMetric.resource.attributes.resourceKey === 'my-resource', 'resourceKey'); | ||
| assert.ok(keys === expectedKeys, 'expectedKeys'); | ||
| assert.ok(consoleMetric.descriptor.name === 'counter_total', 'name'); | ||
| assert.ok(consoleMetric.descriptor.description === 'a test description', 'description'); | ||
| assert.ok(consoleMetric.descriptor.type === 'COUNTER', 'type'); | ||
| assert.ok(consoleMetric.descriptor.unit === '', 'unit'); | ||
| assert.ok(consoleMetric.descriptor.valueType === 1, 'valueType'); | ||
| assert.ok(consoleMetric.dataPoints[0].attributes.key1 === 'attributeValue1', 'ensure metric attributes exists'); | ||
|
|
||
| assert.ok(spyExport.calledOnce); | ||
| }); |
There was a problem hiding this comment.
This code here is not new and has only been moved into a new describe block, as the setup is not needed for the tests that I added.
weyert
approved these changes
Nov 7, 2022
dyladan
approved these changes
Nov 8, 2022
|
Looks good. Seems like this just logs directly the data structure as it comes from the SDK so no real "logic" changes required. All temporality except selection is handled by the SDK |
legendecas
reviewed
Nov 8, 2022
experimental/packages/opentelemetry-sdk-metrics/src/export/AggregationSelector.ts
Outdated
Show resolved
Hide resolved
legendecas
approved these changes
Nov 9, 2022
osherv
approved these changes
Nov 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
As pointed out by @reyang
Originally posted by @reyang in open-telemetry/community#1204 (comment)
Fixes #3395
Short description of the changes
This PR adds configuration options to allow for both DELTA and CUMULATIVE preference in the
ConsoleMetricExporterType of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: