Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[metric spec review] ConsoleExporter should support delta and cumulative #3395

Closed
dyladan opened this issue Nov 7, 2022 · 2 comments · Fixed by #3387
Closed

[metric spec review] ConsoleExporter should support delta and cumulative #3395

dyladan opened this issue Nov 7, 2022 · 2 comments · Fixed by #3387
Assignees
Labels
sdk:metrics Issues and PRs related to the Metrics SDK

Comments

@dyladan
Copy link
Member

dyladan commented Nov 7, 2022

    I haven't looked deeper so I could be wrong, it seems the ConsoleExporter is only supporting CUMULATIVE? https://github.com/open-telemetry/opentelemetry-js/blob/d154066354863e8c682b4aa488d79c7e914bf91c/experimental/packages/opentelemetry-sdk-metrics/src/export/ConsoleMetricExporter.ts#L41

The specification requires both CUMULATIVE and DELTA to be supported https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/metrics/sdk_exporters/stdout.md#opentelemetry-metrics-exporter---standard-output.

InMemoryExporter seems to be covering both

selectAggregationTemporality(_instrumentType: InstrumentType): AggregationTemporality {
.

Originally posted by @reyang in open-telemetry/community#1204 (comment)

@dyladan dyladan changed the title [metric spec review] 7 [metric spec review] ConsoleExporter should support delta and cumulative Nov 7, 2022
@dyladan dyladan added this to the Metrics GA milestone Nov 7, 2022
@pichlermarc
Copy link
Member

Self-assigning as I already have a PR open for that 🙂

@pichlermarc pichlermarc self-assigned this Nov 7, 2022
@legendecas legendecas added the sdk:metrics Issues and PRs related to the Metrics SDK label Nov 7, 2022
@dyladan dyladan modified the milestones: Metrics GA, Metrics After GA Nov 8, 2022
@dyladan
Copy link
Member Author

dyladan commented Nov 8, 2022

Moving to after GA milestone as it isn't a breaking change and there is a blocking comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sdk:metrics Issues and PRs related to the Metrics SDK
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants