Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade linkinator to 4.0.3 #3241

Merged
merged 4 commits into from
Sep 12, 2022

Conversation

pichlermarc
Copy link
Member

Which problem is this PR solving?

We previously rolled back linkinator to 3.0.3 due to some typing issues (#3231) that were introduced by the newer version. 4.0.3 of linkinator fixes this issue by dropping the dependency to update-notifier which used responselike down the chain.

Additional info:

How Has This Been Tested?

  • Running in CI

Checklist:

  • Followed the style guidelines of this project
  • Unit tests have been added
  • Documentation has been updated

@pichlermarc pichlermarc added dependencies Pull requests that update a dependency file Skip Changelog labels Sep 9, 2022
@codecov
Copy link

codecov bot commented Sep 9, 2022

Codecov Report

Merging #3241 (88c2c64) into main (be24d69) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3241   +/-   ##
=======================================
  Coverage   93.30%   93.30%           
=======================================
  Files         202      202           
  Lines        6599     6599           
  Branches     1384     1384           
=======================================
  Hits         6157     6157           
  Misses        442      442           

@pichlermarc pichlermarc marked this pull request as ready for review September 9, 2022 07:48
@pichlermarc pichlermarc requested a review from a team September 9, 2022 07:48
@dyladan dyladan merged commit c1ef97d into open-telemetry:main Sep 12, 2022
@dyladan dyladan deleted the chore/linkinator branch September 12, 2022 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file Skip Changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants