Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): rollback linkinator to 3.0.3 #3231

Merged
merged 1 commit into from
Sep 6, 2022

Conversation

pichlermarc
Copy link
Member

@pichlermarc pichlermarc commented Sep 5, 2022

Which problem is this PR solving?

Hypothesis: For some reason it looks like the type definitions for responselike are missing and this is failing the build while compiling. linkinator depends on this package, and rolling it back to 3.0.3 seems to fix the issue. This issue also only seems to happen in CI and I could not reproduce it on my machine or in docker.

Re-running builds on commits that previously passed now also fail. So this might also be related to caching.

See this week-old commit as an example:

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • Followed the style guidelines of this project
  • Unit tests have been added
  • Documentation has been updated

@codecov
Copy link

codecov bot commented Sep 5, 2022

Codecov Report

Merging #3231 (729ddd7) into main (d3adc22) will increase coverage by 4.74%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3231      +/-   ##
==========================================
+ Coverage   88.02%   92.77%   +4.74%     
==========================================
  Files          32      181     +149     
  Lines         994     5758    +4764     
  Branches      227     1224     +997     
==========================================
+ Hits          875     5342    +4467     
- Misses        119      416     +297     
Impacted Files Coverage Δ
packages/opentelemetry-resources/karma.worker.js 0.00% <0.00%> (-100.00%) ⬇️
...kages/opentelemetry-sdk-trace-base/karma.worker.js 0.00% <0.00%> (-100.00%) ⬇️
...lemetry-resources/src/detectors/BrowserDetector.ts 53.33% <0.00%> (-40.01%) ⬇️
...telemetry-sdk-trace-web/src/StackContextManager.ts
...entelemetry-sdk-trace-web/src/WebTracerProvider.ts
...-sdk-trace-web/src/enums/PerformanceTimingNames.ts
packages/opentelemetry-sdk-trace-web/src/utils.ts
.../src/platform/browser/export/BatchSpanProcessor.ts
...ckages/opentelemetry-sdk-trace-web/karma.worker.js
packages/opentelemetry-sdk-trace-web/src/types.ts
... and 159 more

@pichlermarc pichlermarc marked this pull request as ready for review September 5, 2022 16:00
@pichlermarc pichlermarc requested a review from a team September 5, 2022 16:00
Copy link
Member

@legendecas legendecas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix.

@legendecas legendecas merged commit c926e3d into open-telemetry:main Sep 6, 2022
@dyladan dyladan deleted the fix-build branch September 6, 2022 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants