feat: make scopemanager optional param #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayurkale22
requested review from
bg451,
danielkhan,
iredelmeier,
OlivierAlbertini and
rochdev
as code owners
|
/cc @draffensperger Please review, I can't add as a code reviewer. |
Codecov Report
@@ Coverage Diff @@
## master #257 +/- ##
==========================================
- Coverage 98.94% 98.94% -0.01%
==========================================
Files 66 66
Lines 2652 2648 -4
Branches 173 170 -3
==========================================
- Hits 2624 2620 -4
Misses 28 28
|
mayurkale22
force-pushed
the
optional_scopemanager
branch
from
f47b3f0 to
c75a76c
Compare
draffensperger
approved these changes
Sep 13, 2019
| @@ -35,6 +35,7 @@ import { mergeConfig } from './utility'; | |||
| import { SpanProcessor } from './SpanProcessor'; | |||
| import { NoopSpanProcessor } from './NoopSpanProcessor'; | |||
| import { MultiSpanProcessor } from './MultiSpanProcessor'; | |||
| import { defaultConfig } from './config'; | |||
There was a problem hiding this comment.
Since defaultConfig is a shared immutable constant, should it be DEFAULT_CONFIG in all caps?
mayurkale22
force-pushed
the
optional_scopemanager
branch
from
c8b6411 to
52be98e
Compare
vmarchaud
approved these changes
Sep 13, 2019
|
Ping, for more reviews. |
pichlermarc
pushed a commit
to dynatrace-oss-contrib/opentelemetry-js
that referenced
this pull request
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Originates from API/SDK usage based on current implementation #194
This is as per today's (09/11) SIG discussion. Let me know if you still disagree with this.
BasicTraceris configured withNoopScopeManageras a default value.NodeTraceris configured withAsyncHooksScopeManageras a default value.