Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node-tracer: review if config can be optional when creating it #236

Closed
vmarchaud opened this issue Sep 5, 2019 · 1 comment
Closed

node-tracer: review if config can be optional when creating it #236

vmarchaud opened this issue Sep 5, 2019 · 1 comment
Labels
Discussion Issue or PR that needs/is extended discussion. enhancement New feature or request
Milestone
SDK complete

Comments

@vmarchaud
Copy link
Member

Currently all fields of the config are optional so we may allow later on for it to be optional too for the API to be simpler
@vmarchaud vmarchaud added the bug Something isn't working label Sep 5, 2019
@vmarchaud vmarchaud mentioned this issue Sep 5, 2019
Merged
@mayurkale22 mayurkale22 added Discussion Issue or PR that needs/is extended discussion. enhancement New feature or request and removed bug Something isn't working labels Sep 5, 2019
@mayurkale22 mayurkale22 added this to the SDK complete milestone Sep 5, 2019
@vmarchaud
Copy link
Member Author

I believe its good to close this one since #257 has landed

pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this issue Dec 15, 2023
@dyladan
Merge pull request open-telemetry#236 from renovate-bot/renovate/pin-…
8ca9f6f 
…dependencies

chore(deps): pin dependencies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Discussion Issue or PR that needs/is extended discussion. enhancement New feature or request
Projects
None yet
Milestone
SDK complete
Development

No branches or pull requests
2 participants
@vmarchaud @mayurkale22