Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@opentelemetry/exporter-collector-grpc) regression from #2130 when host specified without protocol #2322

Merged
merged 10 commits into from
Jul 21, 2021

Conversation

lizthegrey
Copy link
Member

Which problem is this PR solving?

Short description of the changes

  • Adds table tests for validateAndNormalizeUrl and corrects issues that prevented them from passing.

@lizthegrey lizthegrey changed the title fix regression from #2130 when host specified without protocol fix(@opentelemetry/exporter-collector-grpc) regression from #2130 when host specified without protocol Jul 5, 2021
@codecov
Copy link

codecov bot commented Jul 5, 2021

Codecov Report

Merging #2322 (afaf085) into main (11719ed) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2322   +/-   ##
=======================================
  Coverage   92.77%   92.77%           
=======================================
  Files         145      145           
  Lines        5221     5221           
  Branches     1070     1070           
=======================================
  Hits         4844     4844           
  Misses        377      377           

@lizthegrey
Copy link
Member Author

browser-tests appears to be a flake

Copy link
Member

@naseemkullah naseemkullah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but I think it would be best to follow the assertion patterns seen in other tests, I left some (untested 😬) comments to adhere to that, this also would mean removing the added chai packages (furthermore i think the hoisted eslint packages are used so probably no need to add them either)

Copy link
Member

@vmarchaud vmarchaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, i agree with @naseemkullah suggestions though

@vmarchaud vmarchaud added the bug Something isn't working label Jul 11, 2021
@lizthegrey
Copy link
Member Author

lgtm, but I think it would be best to follow the assertion patterns seen in other tests, I left some (untested ) comments to adhere to that, this also would mean removing the added chai packages (furthermore i think the hoisted eslint packages are used so probably no need to add them either)

I'll remove the chai packages -- I checked and they were already present as indirect deps but I didn't realize they were only used for tsconfig-paths and not for our stuff.

wrt adding the hoisted eslint -- it makes it easier to have eslint in there so I can run yarn test without pulling all the parent stuff when doing local dev, will defer to what's local project style though.

@lizthegrey lizthegrey requested a review from MSNev July 12, 2021 17:30
@lizthegrey
Copy link
Member Author

PTAL

@dyladan
Copy link
Member

dyladan commented Jul 21, 2021

I don't have permission to update your branch for merge

@lizthegrey
Copy link
Member Author

updated branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants